From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Yanjun Zhu <yanjunz@nvidia.com>,
Alex Dewar <alex.dewar90@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Bob Pearson <rpearsonhpe@gmail.com>,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: FW: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference
Date: Wed, 14 Oct 2020 08:37:28 +0800 [thread overview]
Message-ID: <CAD=hENeBf=u30XWnZFdcZCYGR2Q41HhCFRSduRER=k05zqaCzQ@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB3516EC1E0F28EB8F9B970F24D5050@DM6PR12MB3516.namprd12.prod.outlook.com>
On Wed, Oct 14, 2020 at 8:34 AM Yanjun Zhu <yanjunz@nvidia.com> wrote:
>
>
>
> -----Original Message-----
> From: Alex Dewar <alex.dewar90@gmail.com>
> Sent: Tuesday, October 13, 2020 12:53 AM
> Cc: Alex Dewar <alex.dewar90@gmail.com>; Yanjun Zhu <yanjunz@nvidia.com>; Doug Ledford <dledford@redhat.com>; Jason Gunthorpe <jgg@ziepe.ca>; Bob Pearson <rpearsonhpe@gmail.com>; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] RDMA/rxe: Fix possible NULL pointer dereference
>
> skb_clone() is called without checking if the returned pointer is NULL before it is dereferenced. Fix by adding an additional error check.
>
> Fixes: e7ec96fc7932 ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
> Addresses-Coverity-ID: 1497804: Null pointer dereferences (NULL_RETURNS)
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Thanks a lot.
Zhu Yanjun
> ---
> drivers/infiniband/sw/rxe/rxe_recv.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
> index 11f3daf20768..a65936e12f89 100644
> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
> @@ -266,10 +266,13 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
> /* for all but the last qp create a new clone of the
> * skb and pass to the qp.
> */
> - if (mce->qp_list.next != &mcg->qp_list)
> + if (mce->qp_list.next != &mcg->qp_list) {
> per_qp_skb = skb_clone(skb, GFP_ATOMIC);
> - else
> + if (!per_qp_skb)
> + goto err2;
> + } else {
> per_qp_skb = skb;
> + }
>
> per_qp_pkt = SKB_TO_PKT(per_qp_skb);
> per_qp_pkt->qp = qp;
> @@ -283,6 +286,10 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>
> return;
>
> +err2:
> + spin_unlock_bh(&mcg->mcg_lock);
> + rxe_drop_ref(mcg); /* drop ref from rxe_pool_get_key. */
> +
> err1:
> kfree_skb(skb);
> }
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-14 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:52 [PATCH] RDMA/rxe: Fix possible NULL pointer dereference Alex Dewar
[not found] ` <DM6PR12MB3516EC1E0F28EB8F9B970F24D5050@DM6PR12MB3516.namprd12.prod.outlook.com>
2020-10-14 0:37 ` Zhu Yanjun [this message]
2020-10-16 17:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=hENeBf=u30XWnZFdcZCYGR2Q41HhCFRSduRER=k05zqaCzQ@mail.gmail.com' \
--to=zyjzyj2000@gmail.com \
--cc=alex.dewar90@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).