From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Shoaib Rao <rao.shoaib@oracle.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Bob Pearson <rpearsonhpe@gmail.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v1] RDMA/rxe: Bump up default maximum values used via uverbs
Date: Tue, 28 Sep 2021 14:55:10 +0800 [thread overview]
Message-ID: <CAD=hENeQrNPxjgxbPN0KuKF1XHT+GbEADKX1D3pP0qv=gNXN2Q@mail.gmail.com> (raw)
In-Reply-To: <6a6cede4-32c3-45aa-86f9-4cd35d90ab4f@oracle.com>
On Tue, Sep 28, 2021 at 12:38 PM Shoaib Rao <rao.shoaib@oracle.com> wrote:
>
>
> On 9/27/21 6:46 PM, Zhu Yanjun wrote:
> > On Tue, Sep 28, 2021 at 3:19 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >> On Tue, Sep 14, 2021 at 06:12:20PM -0700, Rao Shoaib wrote:
> >>> In our internal testing we have found that
> >>> default maximum values are too small.
> >>> Ideally there should be no limits, but since
> >>> maximum values are reported via ibv_query_device,
> >>> we have to return some value. So, the default
> >>> maximums have been changed to large values.
> >>>
> >>> Signed-off-by: Rao Shoaib <Rao.Shoaib@oracle.com>
> >>> ---
> >>>
> >>> Resubmitting the patch after applying Bob's latest patches and testing
> >>> using via rping.
> >>>
> >>> drivers/infiniband/sw/rxe/rxe_param.h | 30 ++++++++++++++-------------
> >>> 1 file changed, 16 insertions(+), 14 deletions(-)
> >> So are we good with this? Bob? Zhu?
> > I have already checked this commit. And I have found 2 problems with
> > this commit.
> > This commit changes many MAXs.
> > And now rxe is not stable enough. Not sure this commit will cause the
> > new problems.
> >
> > Zhu Yanjun
>
> Hi Zhu,
>
> A generic statement without any technical data does not help. As far as
> I am aware, currently there are no outstanding issues. If there are,
> please provide data that clearly shows that the issue is caused by this
> patch.
Hi, Shoaib
With this commit, I found 2 problems.
This is why I suspect that this commit will introduce risks.
Before a commit is sent to the upstream, please make full tests with it.
Zhu Yanjun
>
> Thanks you.
>
> Shoaib
>
> >>> - RXE_MAX_MR_INDEX = 0x00010000,
> >>> + RXE_MAX_MR_INDEX = DEFAULT_MAX_VALUE,
> >>> + RXE_MAX_MR = DEFAULT_MAX_VALUE - RXE_MIN_MR_INDEX,
> >> Bob, were you saying this was what needed to be bigger to pass
> >> blktests??
> >>
> >> Jason
next prev parent reply other threads:[~2021-09-28 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 1:12 [PATCH v1] RDMA/rxe: Bump up default maximum values used via uverbs Rao Shoaib
2021-09-27 19:19 ` Jason Gunthorpe
2021-09-28 1:46 ` Zhu Yanjun
2021-09-28 4:38 ` Shoaib Rao
2021-09-28 6:55 ` Zhu Yanjun [this message]
2021-09-28 9:41 ` Shoaib Rao
2021-09-28 9:58 ` Zhu Yanjun
2021-09-29 4:01 ` Shoaib Rao
2021-09-29 5:23 ` Zhu Yanjun
2021-09-29 5:53 ` Shoaib Rao
2021-10-04 18:57 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=hENeQrNPxjgxbPN0KuKF1XHT+GbEADKX1D3pP0qv=gNXN2Q@mail.gmail.com' \
--to=zyjzyj2000@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rao.shoaib@oracle.com \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).