linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Doug Ledford <dledford@redhat.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Moni Shoua <monis@mellanox.com>
Subject: Re: [PATCH] RDMA/rxe: Fix configuration of atomic queue pair attributes
Date: Wed, 19 Feb 2020 08:50:09 +0800	[thread overview]
Message-ID: <CAD=hENfcwDYGwEKG+zz3S7C35y8wrcz=UEvL3WvTnHfZvTeJ-g@mail.gmail.com> (raw)
In-Reply-To: <20200218130942.GB3846@unreal>

Thanks. I am fine with it.

On Tue, Feb 18, 2020 at 9:09 PM Leon Romanovsky <leonro@mellanox.com> wrote:
>
> On Tue, Feb 18, 2020 at 05:53:56PM +0800, Zhu Yanjun wrote:
> > Sorry, when max_rd_atomic will be set to 0?
>
> User can set it.
> ib_uverbs_ex_modify_qp()
>  -> modify_qp()
>   -> ib_modify_qp_with_udata()
>    -> _ib_modify_qp()
>     -> ib_security_modify_qp()
>      -> .modify_q()
>       -> rxe_modify_qp()
>        -> rxe_qp_from_attr()
>
> >
> > Thanks,
> > Zhu Yanjun
> >
> > On Tue, Feb 18, 2020 at 4:59 AM Bart Van Assche <bvanassche@acm.org> wrote:
> > >
> > > From the comment above the definition of the roundup_pow_of_two() macro:
> > >
> > >      The result is undefined when n == 0.
> > >
> > > Hence only pass positive values to roundup_pow_of_two(). This patch fixes
> > > the following UBSAN complaint:
> > >
> > > UBSAN: Undefined behaviour in ./include/linux/log2.h:57:13
> > > shift exponent 64 is too large for 64-bit type 'long unsigned int'
> > > Call Trace:
> > >  dump_stack+0xa5/0xe6
> > >  ubsan_epilogue+0x9/0x26
> > >  __ubsan_handle_shift_out_of_bounds.cold+0x4c/0xf9
> > >  rxe_qp_from_attr.cold+0x37/0x5d [rdma_rxe]
> > >  rxe_modify_qp+0x59/0x70 [rdma_rxe]
> > >  _ib_modify_qp+0x5aa/0x7c0 [ib_core]
> > >  ib_modify_qp+0x3b/0x50 [ib_core]
> > >  cma_modify_qp_rtr+0x234/0x260 [rdma_cm]
> > >  __rdma_accept+0x1a7/0x650 [rdma_cm]
> > >  nvmet_rdma_cm_handler+0x1286/0x14cd [nvmet_rdma]
> > >  cma_cm_event_handler+0x6b/0x330 [rdma_cm]
> > >  cma_ib_req_handler+0xe60/0x22d0 [rdma_cm]
> > >  cm_process_work+0x30/0x140 [ib_cm]
> > >  cm_req_handler+0x11f4/0x1cd0 [ib_cm]
> > >  cm_work_handler+0xb8/0x344e [ib_cm]
> > >  process_one_work+0x569/0xb60
> > >  worker_thread+0x7a/0x5d0
> > >  kthread+0x1e6/0x210
> > >  ret_from_fork+0x24/0x30
> > >
> > > Cc: Moni Shoua <monis@mellanox.com>
> > > Fixes: 8700e3e7c485 ("Soft RoCE driver")
> > > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > > ---
> > >  drivers/infiniband/sw/rxe/rxe_qp.c | 7 ++++---
> > >  1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> > > index ec21f616ac98..6c11c3aeeca6 100644
> > > --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> > > +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> > > @@ -590,15 +590,16 @@ int rxe_qp_from_attr(struct rxe_qp *qp, struct ib_qp_attr *attr, int mask,
> > >         int err;
> > >
> > >         if (mask & IB_QP_MAX_QP_RD_ATOMIC) {
> > > -               int max_rd_atomic = __roundup_pow_of_two(attr->max_rd_atomic);
> > > +               int max_rd_atomic = attr->max_rd_atomic ?
> > > +                       roundup_pow_of_two(attr->max_rd_atomic) : 0;
> > >
> > >                 qp->attr.max_rd_atomic = max_rd_atomic;
> > >                 atomic_set(&qp->req.rd_atomic, max_rd_atomic);
> > >         }
> > >
> > >         if (mask & IB_QP_MAX_DEST_RD_ATOMIC) {
> > > -               int max_dest_rd_atomic =
> > > -                       __roundup_pow_of_two(attr->max_dest_rd_atomic);
> > > +               int max_dest_rd_atomic = attr->max_dest_rd_atomic ?
> > > +                       roundup_pow_of_two(attr->max_dest_rd_atomic) : 0;
> > >
> > >                 qp->attr.max_dest_rd_atomic = max_dest_rd_atomic;
> > >

  reply	other threads:[~2020-02-19  0:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 20:57 [PATCH] RDMA/rxe: Fix configuration of atomic queue pair attributes Bart Van Assche
2020-02-18  9:53 ` Zhu Yanjun
2020-02-18 13:09   ` Leon Romanovsky
2020-02-19  0:50     ` Zhu Yanjun [this message]
2020-02-19  8:30       ` Leon Romanovsky
2020-02-19 20:58 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=hENfcwDYGwEKG+zz3S7C35y8wrcz=UEvL3WvTnHfZvTeJ-g@mail.gmail.com' \
    --to=zyjzyj2000@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=monis@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).