linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Wise <larrystevenwise@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Leon Romanovsky <leon@kernel.org>, wangqi <3100102071@zju.edu.cn>,
	linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: [question]can hard roce and soft roce communicate with each other?
Date: Tue, 3 Dec 2019 15:48:07 -0600	[thread overview]
Message-ID: <CADmRdJcCFYqQ4+gu2yf+UA=m5B4ER8ZJxgb_ebbFTfBi=-4tmQ@mail.gmail.com> (raw)
In-Reply-To: <CADmRdJcQV3hOObZXSQMgJynmFyeWietWb2gffo3T0o5NBPOfNQ@mail.gmail.com>

On Mon, Dec 2, 2019 at 7:57 PM Steve Wise <larrystevenwise@gmail.com> wrote:
>
> Hey Bart,
>
> Well, as long as every implementation supports proper iCRC and RoCE
> standards, I don't see how there could be a problem...
>
> Let me send my patch out now...
>
>
> On Mon, Dec 2, 2019 at 6:57 PM Bart Van Assche <bvanassche@acm.org> wrote:
> >
> > On 11/27/19 6:24 AM, Steve Wise wrote:
> > > I've recently uncovered a bug in RXE that causes iCRC errors when
> > > running between RXE and a correct RoCE implementation.  The bug is
> > > that RXE is not including pad bytes in its iCRC calculations.  So if
> > > the application payload is not 4B aligned then you'll hit this bug.
> > > You can see this by running ib_write_bw, for example, between mlnx_ib
> > > and rxe.
> > >
> > > works:  ib_write_bw -s 32 -n 5
> > > fails: ib_write_bw -s 33 -n 5
> > >
> > > I'll post a patch this coming weekend hopefully.
> >   Hi Steve,
> >
> > Will that patch support coexistence of softRoCE implementations that use
> > different CRC calculation methods?
> >
> > Thanks,
> >
> > Bart.

In case anyone missed it, I posted my fix for unaligned payloads:

https://www.spinics.net/lists/linux-rdma/msg86758.html

Steve.

      reply	other threads:[~2019-12-03 21:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22  7:19 [question]can hard roce and soft roce communicate with each other? wangqi
2019-11-27  0:53 ` Bart Van Assche
2019-11-27 11:10   ` Leon Romanovsky
2019-11-27 14:24     ` Steve Wise
2019-12-03  0:56       ` Bart Van Assche
2019-12-03  1:57         ` Steve Wise
2019-12-03 21:48           ` Steve Wise [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADmRdJcCFYqQ4+gu2yf+UA=m5B4ER8ZJxgb_ebbFTfBi=-4tmQ@mail.gmail.com' \
    --to=larrystevenwise@gmail.com \
    --cc=3100102071@zju.edu.cn \
    --cc=bvanassche@acm.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).