linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Wise <larrystevenwise@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Potnuri Bharat Teja <bharat@chelsio.com>,
	Doug Ledford <dledford@redhat.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/iw_cgxb4: Fix an error handling path in 'c4iw_connect()'
Date: Mon, 18 Nov 2019 11:39:12 -0600	[thread overview]
Message-ID: <CADmRdJcWrsSWSc9_73+V==zbyxoGUdRMVKzOi6bAwVY+5k+cEQ@mail.gmail.com> (raw)
In-Reply-To: <20191115210020.GA29581@ziepe.ca>

Those horrible error labels in cxgb* are my bad.  :(   I now always
use descriptive labels.

Stevo

On Fri, Nov 15, 2019 at 3:01 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Mon, Sep 23, 2019 at 09:07:46PM +0200, Christophe JAILLET wrote:
> > We should jump to fail3 in order to undo the 'xa_insert_irq()' call.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > Not sure which Fixes tag to use because of the many refactorings in this
> > area. So I've choosen to use none :).
> > The issue was already there in 4a740838bf44c. This commit has renamed
> > all labels because a new fail1 was introduced. I've not searched further.
> >
> > Naming of error labels should be improved. Having nowadays a fail5
> > between fail2 and fail3 (because fail5 was the last
> > error handling path added) is not that readable.
> > However, it goes beyong the purpose of this patch.
> >
> > Maybe, just using a fail2a, just as already done in 9f5a9632e412 (which
> > introduced fail5) would be enough.
> > ---
> >  drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> The disaster of the error label aside, this does fix the bug, so
> applied to for-next
>
> Thanks,
> Jason

      reply	other threads:[~2019-11-18 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23 19:07 [PATCH] RDMA/iw_cgxb4: Fix an error handling path in 'c4iw_connect()' Christophe JAILLET
2019-10-01  9:02 ` Dan Carpenter
2019-11-15 21:00 ` Jason Gunthorpe
2019-11-18 17:39   ` Steve Wise [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADmRdJcWrsSWSc9_73+V==zbyxoGUdRMVKzOi6bAwVY+5k+cEQ@mail.gmail.com' \
    --to=larrystevenwise@gmail.com \
    --cc=bharat@chelsio.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).