Linux-RDMA Archive on
 help / color / Atom feed
From: Steve Wise <>
To: Bart Van Assche <>
Cc: linux-rdma <>,
	wangqi <>, Leon Romanovsky <>
Subject: Re: [PATCH 2/2] rxe: correctly calculate iCRC for unaligned payloads
Date: Tue, 3 Dec 2019 12:32:58 -0600
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Dec 3, 2019 at 10:25 AM Bart Van Assche <> wrote:
> On 12/2/19 6:03 PM, Steve Wise wrote:
> > If RoCE PDUs being sent or received contain pad bytes, then the iCRC
> > is miscalculated resulting PDUs being emitted by RXE with an incorrect
> > iCRC, as well as ingress PDUs being dropped due to erroneously detecting
> > a bad iCRC in the PDU.  The fix is to include the pad bytes, if any,
> > in iCRC computations.
> Should this description mention that this patch breaks compatibility
> with SoftRoCE drivers that do not include this fix? Do we need a kernel
> module parameter that allows to select either the old or the new behavior?

Good point.  I defer to others on how they want to handle that.

> > CC:,,
> Should this Cc-line perhaps be converted into three Cc-lines?

Yea I screwed this up.   I really didn't want this in the commit log
vs just CCing on the email submission, but I was having issues with
git send-email.  Pilot error. ;)


  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  2:03 [PATCH 1/2] Update mailmap info for Steve Wise Steve Wise
2019-12-03  2:03 ` [PATCH 2/2] rxe: correctly calculate iCRC for unaligned payloads Steve Wise
2019-12-03 16:25   ` Bart Van Assche
2019-12-03 18:32     ` Steve Wise [this message]
2019-12-04  0:46     ` Doug Ledford
2019-12-09 19:07       ` Doug Ledford
2019-12-10  6:54         ` Leon Romanovsky
2019-12-11  4:24           ` Doug Ledford
2019-12-11  5:59             ` Leon Romanovsky
2019-12-11 14:42             ` Tom Talpey

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on

Archives are clonable:
	git clone --mirror linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ \
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone