From: Oded Gabbay <ogabbay@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Gal Pressman" <galpress@amazon.com>,
"Yossi Leybovich" <sleybo@amazon.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Doug Ledford" <dledford@redhat.com>,
"Dave Airlie" <airlied@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"Christoph Hellwig" <hch@lst.de>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH v6 1/2] habanalabs: define uAPI to export FD for DMA-BUF
Date: Tue, 28 Sep 2021 22:12:45 +0300 [thread overview]
Message-ID: <CAFCwf11_2TTVnqr8HqrsCW6cxUHu9txKuX-3U6mgMVPq8WqKdg@mail.gmail.com> (raw)
In-Reply-To: <20210928171329.GF3544071@ziepe.ca>
On Tue, Sep 28, 2021 at 8:13 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Sun, Sep 12, 2021 at 07:53:08PM +0300, Oded Gabbay wrote:
> > /* HL_MEM_OP_* */
> > __u32 op;
> > - /* HL_MEM_* flags */
> > + /* HL_MEM_* flags.
> > + * For the HL_MEM_OP_EXPORT_DMABUF_FD opcode, this field holds the
> > + * DMA-BUF file/FD flags.
> > + */
> > __u32 flags;
> > /* Context ID - Currently not in use */
> > __u32 ctx_id;
> > @@ -1072,6 +1091,13 @@ struct hl_mem_out {
> >
> > __u32 pad;
> > };
> > +
> > + /* Returned in HL_MEM_OP_EXPORT_DMABUF_FD. Represents the
> > + * DMA-BUF object that was created to describe a memory
> > + * allocation on the device's memory space. The FD should be
> > + * passed to the importer driver
> > + */
> > + __u64 fd;
>
> fd's should be a s32 type in a fixed width uapi.
Yep, will correct this.
>
> I usually expect to see the uapi changes inside the commit that
> consumes them, splitting the patch like this seems strange but
> harmless.
I'll remember that when I send the RDMA patches down the road :)
Thanks,
Oded
>
> Jason
next prev parent reply other threads:[~2021-09-28 19:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 16:53 [PATCH v6 0/2] Add p2p via dmabuf to habanalabs Oded Gabbay
2021-09-12 16:53 ` [PATCH v6 1/2] habanalabs: define uAPI to export FD for DMA-BUF Oded Gabbay
2021-09-28 17:13 ` Jason Gunthorpe
2021-09-28 19:12 ` Oded Gabbay [this message]
2021-09-12 16:53 ` [PATCH v6 2/2] habanalabs: add support for dma-buf exporter Oded Gabbay
2021-09-28 17:36 ` Jason Gunthorpe
2021-09-28 21:17 ` Oded Gabbay
2021-09-30 12:46 ` Oded Gabbay
2021-10-01 14:52 ` Jason Gunthorpe
2021-10-01 14:50 ` Jason Gunthorpe
2021-09-14 14:18 ` [PATCH v6 0/2] Add p2p via dmabuf to habanalabs Daniel Vetter
2021-09-14 14:58 ` Oded Gabbay
2021-09-14 16:12 ` Jason Gunthorpe
2021-09-15 7:45 ` Oded Gabbay
2021-09-16 12:31 ` Daniel Vetter
2021-09-16 12:44 ` Oded Gabbay
2021-09-16 13:16 ` Oded Gabbay
2021-09-17 12:25 ` Daniel Vetter
2021-09-16 13:10 ` Jason Gunthorpe
2021-09-17 12:30 ` Daniel Vetter
2021-09-18 8:38 ` Oded Gabbay
2021-09-23 9:22 ` Oded Gabbay
2021-09-28 7:04 ` Oded Gabbay
2021-09-30 9:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf11_2TTVnqr8HqrsCW6cxUHu9txKuX-3U6mgMVPq8WqKdg@mail.gmail.com \
--to=ogabbay@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=galpress@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=leonro@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).