From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D18C433E0 for ; Tue, 19 May 2020 16:00:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03E3F207C4 for ; Tue, 19 May 2020 16:00:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="HUye97v9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729358AbgESQAx (ORCPT ); Tue, 19 May 2020 12:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729211AbgESQAx (ORCPT ); Tue, 19 May 2020 12:00:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5CC5C08C5C1 for ; Tue, 19 May 2020 09:00:52 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id m185so4216965wme.3 for ; Tue, 19 May 2020 09:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BmLSEBizF5QwZ0w8Jva6N+7I89XZ83pvn5mbF9AauMU=; b=HUye97v9LyaMSqw+E/FpZNDbsO1SE7ChWSkscNuv36LxUKxH75OYus+P3faHzhBoqi rj3XrNuC46MBLrShN1dnuZCq/p1g10z0xrFWbyR6ZQ4bI+jQOv6PxOzZWOBoxYPB4PYQ qD02Ae2iMjJ03oj8UUmIxDfqXCnVUZkJCHfm11m7Uo7y2Cg0Hyhz1koszly6B0XEM+Ht pXCSUG/KYJQ7z1PkuDcPE1AfAMCSqxeh5Gm7rdsvniueOTeOAgH00AMlcPh/qaVZdrE+ zqOSt+Gs4dMmsPNa+5nzpyXtscCz4Qf3qLQD23/WpAv1zrnUy/oEyN4BIF+uuiRqqEl3 fL8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BmLSEBizF5QwZ0w8Jva6N+7I89XZ83pvn5mbF9AauMU=; b=oZZO5x79/oJdD504nNUoT8IUrnLEJCPLB0/ZF0K2guhT2pwXqzXgGzmwxL+6Hbc2Kq BI632pZCXaGzHKuIoby2GecR952XX2istOnM50CCAcY/0yGryQv7OZnzH4MhQ9dokqwx +ROSGK9h7bYQ9LgsbmmJcmY2DE/cWwvAoiRvNk9WKkqF5b9E7Fl5z5IroyU4ovOcRixL ITmUQ9kLiT2fPRBiRDd/Pdho65BtJE/UpeQfjjhy5IvZrVACrBP7KcA04rl6DabybK0t 5q8iYHxvZRWu+u1VwgFoE5xkGgsSLZZy5a+UGNQCH+jTiMtAJ2oFZA+A7scKMDbWHV13 xPNA== X-Gm-Message-State: AOAM531omgSr2mDS6+yg0mfBhP6g4E6/oDSE7FGPCmryd0/MsBqCXVpx wNHIr46NTJfpWZe/NPCtYW6Jh0hbRny1w10u1kdH X-Google-Smtp-Source: ABdhPJw/YCnRJY1GgnQdvj+SGYyFtn5wisFibQeDNsvksIsO3xMvENa+bKnM4fLCF0BfmetWSDDTVY4TjPINiLA/d9w= X-Received: by 2002:a1c:5402:: with SMTP id i2mr44858wmb.185.1589904051546; Tue, 19 May 2020 09:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20200519154525.GA66801@mwanda> In-Reply-To: <20200519154525.GA66801@mwanda> From: Danil Kipnis Date: Tue, 19 May 2020 18:00:40 +0200 Message-ID: Subject: Re: [PATCH] RDMA/rtrs: Fix a couple off by one bugs in rtrs_srv_rdma_done() To: Dan Carpenter Cc: Jack Wang , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, May 19, 2020 at 5:45 PM Dan Carpenter wrote: > > These > comparisons should be >= to prevent accessing one element > beyond the end of the buffer. > > Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") > Signed-off-by: Dan Carpenter > --- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > index 658c8999cb0d..0b53b79b0e27 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > @@ -1213,8 +1213,8 @@ static void rtrs_srv_rdma_done(struct ib_cq *cq, struct ib_wc *wc) > > msg_id = imm_payload >> sess->mem_bits; > off = imm_payload & ((1 << sess->mem_bits) - 1); > - if (unlikely(msg_id > srv->queue_depth || > - off > max_chunk_size)) { > + if (unlikely(msg_id >= srv->queue_depth || > + off >= max_chunk_size)) { > rtrs_err(s, "Wrong msg_id %u, off %u\n", > msg_id, off); > close_sess(sess); > -- > 2.26.2 > Thanks a lot, Dan! Acked-by: Danil Kipnis