From: Haris Iqbal <haris.iqbal@ionos.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jack Wang <jinpu.wang@ionos.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Md Haris Iqbal <haris.iqbal@cloud.ionos.com>,
Gioh Kim <gi-oh.kim@ionos.com>
Subject: Re: [PATCH for-next 09/10] RDMA/rtrs: Add support to disable an IB port on the storage side
Date: Mon, 2 Aug 2021 19:43:05 +0200 [thread overview]
Message-ID: <CAJpMwygeu=LYdTWMHxWYHMe_==yHxB_KEsTstH3CWOaMWu0sgQ@mail.gmail.com> (raw)
In-Reply-To: <YQge6yQTILQsQECO@unreal>
On Mon, Aug 2, 2021 at 6:36 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Aug 02, 2021 at 04:31:01PM +0200, Haris Iqbal wrote:
> > On Mon, Aug 2, 2021 at 9:30 AM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Fri, Jul 30, 2021 at 03:18:31PM +0200, Jack Wang wrote:
> > > > From: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
> > > >
> > > > This commit adds support to reject connection on a specific IB port which
> > > > can be specified in the added sysfs entry for the rtrs-server module.
> > > >
> > > > Example,
> > > >
> > > > $ echo "mlx4_0 1" > /sys/class/rtrs-server/ctl/disable_port
> > > >
> > > > When a connection request is received on the above IB port, rtrs_srv
> > > > rejects the connection and notifies the client to disable reconnection
> > > > attempts. A manual reconnect has to be triggerred in such a case.
> > > >
> > > > A manual reconnect can be triggered by doing the following,
> > > >
> > > > echo 1 > /sys/class/rtrs-client/blya/paths/<select-path>/reconnect
>
> <...>
>
> > >
> > > And maybe Jason thinks differently, but I don't feel comfortable with
> > > such new sysfs file at all.
>
> This part is much more important and should be cleared before resending.
Agreed. I will wait for Jason to respond.
>
> > >
> > > Thanks
next prev parent reply other threads:[~2021-08-02 17:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 13:18 [PATCH for-next 00/10] Misc update for RTRS Jack Wang
2021-07-30 13:18 ` [PATCH for-next 01/10] RDMA/rtrs-clt: During add_path change for_new_clt according to path_num Jack Wang
2021-08-02 6:40 ` Leon Romanovsky
2021-08-02 14:17 ` Haris Iqbal
2021-07-30 13:18 ` [PATCH for-next 02/10] RDMA/rtrs-srv: Prevent sysfs error with path name "ctl" Jack Wang
2021-08-02 6:47 ` Leon Romanovsky
2021-08-02 14:24 ` Haris Iqbal
2021-08-02 16:34 ` Leon Romanovsky
2021-07-30 13:18 ` [PATCH for-next 03/10] RDMA/rtrs: Use sysfs_emit instead of s*printf function for sysfs show Jack Wang
2021-08-02 6:52 ` Leon Romanovsky
2021-08-02 14:18 ` Haris Iqbal
2021-07-30 13:18 ` [PATCH for-next 04/10] RDMA/rtrs: Remove unused functions Jack Wang
2021-08-02 6:53 ` Leon Romanovsky
2021-07-30 13:18 ` [PATCH for-next 05/10] RDMA/rtrs: Fix warning when use poll mode Jack Wang
2021-08-02 7:06 ` Leon Romanovsky
2021-08-02 14:18 ` Haris Iqbal
2021-07-30 13:18 ` [PATCH for-next 06/10] RDMA/rtrs: Remove len parameter from helper print functions of sysfs Jack Wang
2021-08-02 7:08 ` Leon Romanovsky
2021-08-02 14:34 ` Haris Iqbal
2021-07-30 13:18 ` [PATCH for-next 07/10] RDMA/rtrs: Remove all likely and unlikely Jack Wang
2021-08-02 7:10 ` Leon Romanovsky
2021-07-30 13:18 ` [PATCH for-next 08/10] RDMA/rtrs-clt: Fix counting inflight IO Jack Wang
2021-08-02 7:22 ` Leon Romanovsky
2021-07-30 13:18 ` [PATCH for-next 09/10] RDMA/rtrs: Add support to disable an IB port on the storage side Jack Wang
2021-08-02 7:29 ` Leon Romanovsky
2021-08-02 14:31 ` Haris Iqbal
2021-08-02 16:35 ` Leon Romanovsky
2021-08-02 17:43 ` Haris Iqbal [this message]
2021-08-06 1:22 ` Jason Gunthorpe
2021-08-06 10:14 ` Haris Iqbal
2021-07-30 13:18 ` [PATCH for-next 10/10] RDMA/rtrs: remove (void) casting for functions Jack Wang
2021-08-02 7:32 ` Leon Romanovsky
2021-08-02 14:16 ` Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJpMwygeu=LYdTWMHxWYHMe_==yHxB_KEsTstH3CWOaMWu0sgQ@mail.gmail.com' \
--to=haris.iqbal@ionos.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=gi-oh.kim@ionos.com \
--cc=haris.iqbal@cloud.ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).