linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Jason Gunthorpe <jgg@mellanox.com>,
	David Miller <davem@davemloft.net>,
	Doug Ledford <dledford@redhat.com>,
	Sindhu Devale <sindhu.devale@intel.com>,
	Netdev <netdev@vger.kernel.org>,
	linux-rdma@vger.kernel.org, Neil Horman <nhorman@redhat.com>,
	Stefan Assmann <sassmann@redhat.com>,
	John Greene <jogreene@redhat.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>
Subject: Re: [net-next] i40iw/i40e: Remove link dependency on i40e
Date: Wed, 23 May 2018 08:03:44 -0700	[thread overview]
Message-ID: <CAKgT0UeZRZ8O3PQWSz2Wod8HNjwc_bcuqqb70A7qypPn5kzW+Q@mail.gmail.com> (raw)
In-Reply-To: <20180523061922.GA4753@infradead.org>

On Tue, May 22, 2018 at 11:19 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote:
>> > Why would you want to do this? The rdma driver is non-functional
>> > without the ethernet driver, so why on earth would we want to defeat
>> > the module dependency mechanism?
>>
>> This change is driven by the OSV's like Red Hat, where customer's were
>> updating the i40e driver, which in turn broke i40iw.
>
> Doctor it hurts when I do this..
>
> There is no reason to make a mess of our drivers because people are
> doing things they should haver never done and that aren't supported
> in Linux.
>
> If Intel didn;t offer any out of tree drivers I'm pretty sure no
> customer would even attempt this.  So fix this where the problem is.

Are you serious? You are never going to see out-of-tree drivers go
away. They exist for the simple reason that most customers/OSVs are
slow to upgrade their kernels so we have people running on a 3.10
something kernel on their RHEL 7.X and want to use the latest greatest
hardware.

I find it ridiculous that you expect us to support a product with
in-kernel only and it is pretty short sighted to insist that that is
the only way to support a product.

With that said it probably wouldn't hurt to throw a WARN_ONCE in here
somewhere that basically informs the user they are doing something
stupid and essentially disabling the i40iw driver if they remove i40e.

- Alex

  reply	other threads:[~2018-05-23 15:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 20:38 Jeff Kirsher
2018-05-22 20:56 ` Jason Gunthorpe
2018-05-22 21:04   ` Jeff Kirsher
2018-05-22 21:33     ` Jason Gunthorpe
2018-05-22 21:50       ` Jeff Kirsher
2018-05-22 21:54         ` Jason Gunthorpe
2018-05-23  6:20         ` Christoph Hellwig
2018-05-23  6:19     ` Christoph Hellwig
2018-05-23 15:03       ` Alexander Duyck [this message]
2018-05-23 15:18         ` Jason Gunthorpe
2018-05-23 19:00 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKgT0UeZRZ8O3PQWSz2Wod8HNjwc_bcuqqb70A7qypPn5kzW+Q@mail.gmail.com \
    --to=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=hch@infradead.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jgg@mellanox.com \
    --cc=jogreene@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    --cc=shiraz.saleem@intel.com \
    --cc=sindhu.devale@intel.com \
    --subject='Re: [net-next] i40iw/i40e: Remove link dependency on i40e' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox