From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F01C35242 for ; Tue, 11 Feb 2020 21:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C2CF20842 for ; Tue, 11 Feb 2020 21:44:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dev-mellanox-co-il.20150623.gappssmtp.com header.i=@dev-mellanox-co-il.20150623.gappssmtp.com header.b="q10Zmw35" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727569AbgBKVoe (ORCPT ); Tue, 11 Feb 2020 16:44:34 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37249 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbgBKVoe (ORCPT ); Tue, 11 Feb 2020 16:44:34 -0500 Received: by mail-lj1-f194.google.com with SMTP id v17so13353613ljg.4 for ; Tue, 11 Feb 2020 13:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev-mellanox-co-il.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FCK0sjqQ6cf0msl3lwipyWtRkRUXU+cty6zPWQtzLQE=; b=q10Zmw35nWzQ+Ks+WJkGDdW8XCtpT85M4eQqywc2ctI6T4G5zUSfHVSVfDXoeczmZ6 KqDhcFVNDXgUGxxf685OTB2vgSgSt3s1BDrP4zBza1y29niy1aVn3bTS1wyTDfCztCna tRIJ8taz2VeW7Yvqb7M4iOlKVs+yTH4Zv+lRZ3wVeMnpt8whWRc8S8gdBYKrsFkGl2kM 2yau7YRTJU+uhvYM6njqf3WJVZcnsuUpUGq23OMn5RF3Ix91D9KciE0tY/m4U0P0vo6C +YvPT6pQyjD2h7SDl2jwxFvAzKUnFvMGv9+yBU+9dfVyy/VpXxREhblkFFGOebNdMJWw muHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FCK0sjqQ6cf0msl3lwipyWtRkRUXU+cty6zPWQtzLQE=; b=h6otnXFD9glJjzPtOYN4voINxDY40rmL748PiByUW1NCjnAvcjUHa86N7iNntXhDGd BNiCIXcNZiAlZcXGgaCL3a2W4pynSWxr5OHYu/as+nk/Ga9OT18gWIFfBYoRVFV/7ufV kSKXuBVjr+/hzvD1zRBNVHxnY++PNtGglKm1+6cy+eItmP9BXPajh2sqoMEhffEmgyi7 fv51Oe6kHxWliVoY9mkS/HtpfOsv4QxyaaAGadAEuU0NxwshtnpUesz0Xm/d9c9GbmwR XSwyxwdk3qYxCMWtd7xeCISuZKlFzKZnWxvyY9OBIlB/PMnvNoAt3ZbBncApRfZolXiM l/Mg== X-Gm-Message-State: APjAAAUL4x7dCXWW0mUUjk2rpXvSi2uCHVMYUPhvA1N8l1bZrEyg0qk0 Vl7fVo481TQKKJ6GxhE+faI/RU+sx8du/Kb1+cfNNw== X-Google-Smtp-Source: APXvYqzbGwK9xhWlDNmDqBmMndHvGHadA0WVrHPIzqAN+tt/TmeaBdatK4HRV1EWwnNItMxWoK9IsSUjpN3Y4AgupfM= X-Received: by 2002:a2e:89cd:: with SMTP id c13mr5429721ljk.139.1581457472754; Tue, 11 Feb 2020 13:44:32 -0800 (PST) MIME-Version: 1.0 References: <20200126175104.17948-1-christophe.jaillet@wanadoo.fr> In-Reply-To: From: Saeed Mahameed Date: Tue, 11 Feb 2020 13:44:21 -0800 Message-ID: Subject: Re: [PATCH] net/mlx5: Remove a useless 'drain_workqueue()' call in 'mlx5e_ipsec_cleanup()' To: Boris Pismenny Cc: Christophe JAILLET , Saeed Mahameed , "leon@kernel.org" , "davem@davemloft.net" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jan 27, 2020 at 12:08 AM Boris Pismenny wrote: > > > On 1/26/2020 7:51 PM, Christophe JAILLET wrote: > > 'destroy_workqueue()' already calls 'drain_workqueue()', there is no need > > to call it explicitly. > > > > Signed-off-by: Christophe JAILLET > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > index cf58c9637904..29626c6c9c25 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c > > @@ -433,7 +433,6 @@ void mlx5e_ipsec_cleanup(struct mlx5e_priv *priv) > > if (!ipsec) > > return; > > > > - drain_workqueue(ipsec->wq); > > destroy_workqueue(ipsec->wq); > > > > ida_destroy(&ipsec->halloc); > LGTM applied to net-next-mlx5 Thanks!