From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B52C43331 for ; Tue, 31 Mar 2020 07:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B90F0206F6 for ; Tue, 31 Mar 2020 07:13:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="KRLxEykP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgCaHNS (ORCPT ); Tue, 31 Mar 2020 03:13:18 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:36283 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbgCaHNS (ORCPT ); Tue, 31 Mar 2020 03:13:18 -0400 Received: by mail-io1-f68.google.com with SMTP id n10so6561996iom.3 for ; Tue, 31 Mar 2020 00:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q6vgJdAZ89ozStkYrjfd7BJEU9NXvocN/bsECgDGewg=; b=KRLxEykPXgAZxv80UQdsD+hUH1MSMUcppDC0CHddQ+S+BDUIQ4utaMPFTrdx6BN//V GMsH4YveCgbgt4ZCBjv6n+5rZc02LM6bEf7aZYLZ6d1RN+Obt62G2+hSdx3863JAqQ9s swQKqydIImi9KkbIJCnQjYxQ539P9h/6RpqtngCh9NQ74Ev04B/aJcMecIlt+Qt1dnOt GeeyTg5l1VWmb3odR4s6GQhN4xh1nxS9YJt8UMFW43qVWfc6L293jmtTz6fNxa3wWLA/ 6jGB+tU2/2HbNZtmfLQAuJVVVFUKvIRO0Zy6LwO3cdX2PcU9BoD8s/pxlvJaZ4iQ2R5H ydbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q6vgJdAZ89ozStkYrjfd7BJEU9NXvocN/bsECgDGewg=; b=MwLp73qU8T95xhhbcsvo87q4iZ4eTMFRio8lRuXm2B3Zl/dnu8ombpoEHLe/dRWwVh qI3/s+5QTCZIUQCsM1M1IjeFJ03lyl80z7XAdBx71AEqJlrYEmnG0ZvXAh2SIYHGUpbX YYuHq70K/LOrYXqetBwHGPEn3b82bi3iDOR0gPK0cPwFSclxogQNjKp/GIGQg7lRC41x Nxb2XaTBX2hXqUHjzAkSNAIWZdRyPqqs24NlLAhr/RuaC3qdejxFmON+tWzJFqM2K3C8 xeH0eLYBkxUY9OyFFwpyVmUl4xOPBlfuA/f2q88+S7OM4bkty+3raBCuZvvZrvJ5jnRV cyrA== X-Gm-Message-State: ANhLgQ1NbYorZzIysICBdpxBzurqWeTvmdouPO+TEDjP99u2mP/xt4Ya 07gNV5BqWYf3Sa5X+k+/wFdcSNWrG76cxrpdrqBL1w== X-Google-Smtp-Source: ADFU+vuRkzNkkHa4LdGVy9jE/I0zEoqT0skNgUuQPdihENGuuiv27aCbuPj1QF5xAbO8ssxqAb823TT2ni2XDJ3VGBE= X-Received: by 2002:a6b:b70a:: with SMTP id h10mr14387625iof.54.1585638796881; Tue, 31 Mar 2020 00:13:16 -0700 (PDT) MIME-Version: 1.0 References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com> <20200320121657.1165-13-jinpu.wang@cloud.ionos.com> <9ecaaa54-9aa2-958e-e741-c908fee60a83@acm.org> In-Reply-To: <9ecaaa54-9aa2-958e-e741-c908fee60a83@acm.org> From: Jinpu Wang Date: Tue, 31 Mar 2020 09:13:06 +0200 Message-ID: Subject: Re: [PATCH v11 12/26] RDMA/rtrs: server: sysfs interface functions To: Bart Van Assche Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Jason Gunthorpe , Danil Kipnis , Roman Penyaev , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Mar 31, 2020 at 12:29 AM Bart Van Assche wrote: > > On 2020-03-20 05:16, Jack Wang wrote: > > +static struct kobj_type ktype = { > > + .sysfs_ops = &kobj_sysfs_ops, > > +}; > > It seems like a release method is missing here. Will fix, thanks Bart!