From: Cong Wang <xiyou.wangcong@gmail.com>
To: Gi-Oh Kim <gi-oh.kim@profitbricks.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Noam Rathaus <noamr@beyondsecurity.com>,
Sean Hefty <sean.hefty@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] infiniband: fix a possible use-after-free bug
Date: Mon, 4 Jun 2018 09:30:34 -0700 [thread overview]
Message-ID: <CAM_iQpV2PJZUQEcXh=TpHRZzLEqGLDAQ1j1_ibPY_kNfbWoAEQ@mail.gmail.com> (raw)
In-Reply-To: <CAJX1YtZNdwiwPmj5gGTqURjvLqa5g7Ly_h+TEZfNJSW=mrqRiQ@mail.gmail.com>
On Mon, Jun 4, 2018 at 9:23 AM, Gi-Oh Kim <gi-oh.kim@profitbricks.com> wrote:
> Hi,
>
> Your patch is reasonable to me.
> Can I ask a question for that?
> Could it be solved by asymmetric locking as following?
Maybe, if you are sure taking file->mut is safe in that place.
Can you double check atomic_inc_not_zero(&mc->ctx->ref)?
I am too far away from familiar with infiniband. ;)
next prev parent reply other threads:[~2018-06-04 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 18:31 [PATCH] infiniband: fix a possible use-after-free bug Cong Wang
2018-06-04 16:23 ` Gi-Oh Kim
2018-06-04 16:30 ` Cong Wang [this message]
2018-06-04 16:46 ` Jason Gunthorpe
2018-06-04 16:52 ` Gi-Oh Kim
2018-06-04 16:42 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpV2PJZUQEcXh=TpHRZzLEqGLDAQ1j1_ibPY_kNfbWoAEQ@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=dledford@redhat.com \
--cc=gi-oh.kim@profitbricks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=noamr@beyondsecurity.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).