From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Netdev <netdev@vger.kernel.org>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency
Date: Sun, 18 Apr 2021 00:09:16 +0530 [thread overview]
Message-ID: <CANjDDBgsh9FrQOgB-uR0GGYZHcF5cnTy4Efnd3L_-T2_eWqxsg@mail.gmail.com> (raw)
In-Reply-To: <YHqY8Led24PuLU5W@unreal>
[-- Attachment #1: Type: text/plain, Size: 5224 bytes --]
On Sat, Apr 17, 2021 at 1:44 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote:
> > On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote:
> > > > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky <leon@kernel.org> wrote:
> > > > >
> > > > > On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote:
> > > > > > On Sat, Apr 3, 2021 at 5:12 PM Leon Romanovsky <leon@kernel.org> wrote:
> > > > > > >
> > > > > > > On Sat, Apr 03, 2021 at 03:52:13PM +0530, Devesh Sharma wrote:
> > > > > > > > On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky <leon@kernel.org> wrote:
> > > > > > > > >
> > > > > > > > > From: Leon Romanovsky <leonro@nvidia.com>
> > > > > > > > >
> > > > > > > > > Changelog:
> > > > > > > > > v2:
> > > > > > > > > * kbuild spotted that I didn't delete all code in patch #5, so deleted
> > > > > > > > > even more ulp_ops derefences.
> > > > > > > > > v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-leon@kernel.org
> > > > > > > > > * Go much deeper and removed useless ULP indirection
> > > > > > > > > v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org
> > > > > > > > > -----------------------------------------------------------------------
> > > > > > > > >
> > > > > > > > > The following series fixes issue spotted in [1], where bnxt_re driver
> > > > > > > > > messed with module reference counting in order to implement symbol
> > > > > > > > > dependency of bnxt_re and bnxt modules. All of this is done, when in
> > > > > > > > > upstream we have only one ULP user of that bnxt module. The simple
> > > > > > > > > declaration of exported symbol would do the trick.
> > > > > > > > >
> > > > > > > > > This series removes that custom module_get/_put, which is not supposed
> > > > > > > > > to be in the driver from the beginning and get rid of nasty indirection
> > > > > > > > > logic that isn't relevant for the upstream code.
> > > > > > > > >
> > > > > > > > > Such small changes allow us to simplify the bnxt code and my hope that
> > > > > > > > > Devesh will continue where I stopped and remove struct bnxt_ulp_ops too.
> > > > > > > > >
> > > > > > > > > Thanks
> > > > > > > > >
> > > > > > > > > [1] https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org
> > > > > > > > >
> > > > > > > > > Leon Romanovsky (5):
> > > > > > > > > RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it
> > > > > > > > > RDMA/bnxt_re: Create direct symbolic link between bnxt modules
> > > > > > > > > RDMA/bnxt_re: Get rid of custom module reference counting
> > > > > > > > > net/bnxt: Remove useless check of non-existent ULP id
> > > > > > > > > net/bnxt: Use direct API instead of useless indirection
> > > > > > > > >
> > > > > > > > > drivers/infiniband/hw/bnxt_re/Kconfig | 4 +-
> > > > > > > > > drivers/infiniband/hw/bnxt_re/main.c | 93 ++-----
> > > > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +-
> > > > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
> > > > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 245 +++++++-----------
> > > > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 32 +--
> > > > > > > > > 6 files changed, 119 insertions(+), 260 deletions(-)
> > > > > > > >
> > > > > > > > Hi Leon,
> > > > > > > >
> > > > > > > > After a couple of internal discussions we reached a conclusion to
> > > > > > > > implement the Auxbus driver interface and fix the problem once and for
> > > > > > > > all.
> > > > > > >
> > > > > > > Thanks Devesh,
> > > > > > >
> > > > > > > Jason, it looks like we can proceed with this patchset, because in
> > > > > > > auxbus mode this module refcount and ULP indirection logics will be
> > > > > > > removed anyway.
> > > > > > >
> > > > > > > Thanks
> > > > > > Hi Leon,
> > > > > >
> > > > > > In my internal testing, I am seeing a crash using the 3rd patch. I am
> > > > > > spending a few cycles on debugging it. expect my input in a day or so.
> > > > >
> > > > > Can you please post the kernel crash report here?
> > > > > I don't see how function rename in patch #3 can cause to the crash.
> > > > Hey, unfortunately my kdump service config is giving me tough time on
> > > > my host. I will share if I get it.
> > >
> > > Any news here?
> > Expect something by this Friday. yesterday was a holiday in India.
>
> Any update?
> This series is close to three weeks already and I would like to progress with it.
Hi Leon,
The host crash I indicated earlier is actually caused by patch 4 and
not by patch 3 from this series. I spent time to root cause the
problem and realized that patch-4 is touching quite many areas which
would require much intrusive testing and validation.
As I indicated earlier, we are implementing the PCI Aux driver
interface at a faster pace. While PCI Aux changes are in progress we
are willing to retain the existing bnxt_re and bnxt_en interface
untouched.
The problem of module referencing would be rectified with PCI aux
change by inheritance.
>
> Thanks
--
-Regards
Devesh
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-04-17 18:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 6:57 [PATCH rdma-next v2 0/5] Get rid of custom made module dependency Leon Romanovsky
2021-04-01 6:57 ` [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it Leon Romanovsky
2021-04-21 17:50 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules Leon Romanovsky
2021-04-21 17:51 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 3/5] RDMA/bnxt_re: Get rid of custom module reference counting Leon Romanovsky
2021-04-21 17:52 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 4/5] net/bnxt: Remove useless check of non-existent ULP id Leon Romanovsky
2021-04-01 6:57 ` [PATCH rdma-next v2 5/5] net/bnxt: Use direct API instead of useless indirection Leon Romanovsky
2021-04-03 10:22 ` [PATCH rdma-next v2 0/5] Get rid of custom made module dependency Devesh Sharma
2021-04-03 11:42 ` Leon Romanovsky
2021-04-08 11:36 ` Devesh Sharma
2021-04-08 11:44 ` Leon Romanovsky
2021-04-08 11:53 ` Jason Gunthorpe
2021-04-08 12:03 ` Leon Romanovsky
2021-04-08 15:21 ` Devesh Sharma
2021-04-08 15:12 ` Devesh Sharma
2021-04-12 7:40 ` Leon Romanovsky
2021-04-14 13:45 ` Devesh Sharma
2021-04-17 8:14 ` Leon Romanovsky
2021-04-17 18:39 ` Devesh Sharma [this message]
2021-04-18 4:18 ` Leon Romanovsky
2021-04-19 17:38 ` Jason Gunthorpe
2021-04-19 19:04 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANjDDBgsh9FrQOgB-uR0GGYZHcF5cnTy4Efnd3L_-T2_eWqxsg@mail.gmail.com \
--to=devesh.sharma@broadcom.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).