Re: [PATCH v8] libibverbs: display gid type in ibv_devinfo

[Devesh Sharma <devesh.sharma@broadcom.com>]

On Wed, Feb 12, 2020 at 11:25 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Feb 10, 2020 at 12:17:45PM -0500, Devesh Sharma wrote:
> > It becomes difficult to make out from the output of ibv_devinfo
> > if a particular gid index is RoCE v2 or not.
> >
> > Adding a string to the output of ibv_devinfo -v to display the
> > gid type at the end of gid.
> >
> > The output would look something like below:
> > $ ibv_devinfo -v -d bnxt_re2
> > hca_id: bnxt_re2
> >  transport:             InfiniBand (0)
> >  fw_ver:                216.0.220.0
> >  node_guid:             b226:28ff:fed3:b0f0
> >  sys_image_guid:        b226:28ff:fed3:b0f0
> >   .
> >   .
> >   .
> >   .
> >       phys_state:     LINK_UP (5)
> >       GID[  0]:       fe80:0000:0000:0000:b226:28ff:fed3:b0f0, RoCE v1
> >       GID[  1]:       fe80::b226:28ff:fed3:b0f0, RoCE v2
> >       GID[  2]:       0000:0000:0000:0000:0000:ffff:c0aa:0165, RoCE v1
> >       GID[  3]:       ::ffff:192.170.1.101, RoCE v2
> > $
> > $
> > $
> >
> > Reviewed-by: Jason Gunthrope <jgg@ziepe.ca>
> > Reviewed-by: Gal Pressman <galpress@amazon.com>
> > Reviewed-by: Parav Pandit <parav@mellanox.com>
> > Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> > ---
> >  libibverbs/examples/devinfo.c | 61 ++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 49 insertions(+), 12 deletions(-)
> >
>
> Devesh,
>
> I see that everyone is happy now, can you please refresh PR so I will
> merge it?
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Done

Thanks!