From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F570C352A4 for ; Wed, 12 Feb 2020 18:53:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A2B324683 for ; Wed, 12 Feb 2020 18:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="aRvJoJnJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbgBLSxS (ORCPT ); Wed, 12 Feb 2020 13:53:18 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:44675 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727231AbgBLSxS (ORCPT ); Wed, 12 Feb 2020 13:53:18 -0500 Received: by mail-io1-f68.google.com with SMTP id z16so3434745iod.11 for ; Wed, 12 Feb 2020 10:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xMqI5ZJM87r+yi61ZF0ys+vNtYVMECXl7SBwCn+sqBw=; b=aRvJoJnJlDI1uAsAqm/931tOQpwGkwtnX2TOkHlGTGccPE0sr2U53OxVCWZx5rsjLu R5P4mcmKWGQhpTuD0E9vvN5/W+rWvZBI45YQTOBtYZNOmK/ODZF7vTJUjfzJPeZM6A5r KmGXgmDOUo4JO1K+KL4QDieUT6a6DnqEH5Ink= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xMqI5ZJM87r+yi61ZF0ys+vNtYVMECXl7SBwCn+sqBw=; b=rgPCiszJ0+fwBWcQZ/WNYAZamGumEtB7ha+FwTce+M8hSxydoBIg9nSDxwzx56i1rF mm/e/nZA/Uhsfe5bY0vjx+0cpr4cS7jaw/Bmi0yfSV6ah0wOKA42jt6tibYlQiamahHW GocP14Ovg6FNbidwP9Cn6M5nqu/HcfAD9r00KRv8YPS7Td716hjSZmjtboKtOBADC3Ab QeKb2frhzPl7mUMRd7vdxG84HpUIijlzOZ8ScBOenIy9+2ufQHWlgXIo8R6od0ohMmlK DrvBMPOffYw+9MuGrH0DIFvGRQXJ6tKmYJR6kC3rf7RwqUor/8BqaIJHJD28Ak+T8j4T qQ4Q== X-Gm-Message-State: APjAAAWW+JfjhczKs0LdqLor9oK0lgZsaHa7tJc+SrISgekICdsxDqrg VQR5wp+mvhNClu2uUe1bG1gwbJAuuIh62Sk/QmQeeijY X-Google-Smtp-Source: APXvYqxFKaEHubazw2k56bLUNwBZ+R/98YOC6YVndnGFZe9+MZCcviQRv6bYDZZtp3mhI9ecNJq5YroSNGz+KznLblg= X-Received: by 2002:a02:2404:: with SMTP id f4mr19572819jaa.50.1581533597079; Wed, 12 Feb 2020 10:53:17 -0800 (PST) MIME-Version: 1.0 References: <1581355065-763-1-git-send-email-devesh.sharma@broadcom.com> <20200212175458.GE679970@unreal> In-Reply-To: <20200212175458.GE679970@unreal> From: Devesh Sharma Date: Thu, 13 Feb 2020 00:22:40 +0530 Message-ID: Subject: Re: [PATCH v8] libibverbs: display gid type in ibv_devinfo To: Leon Romanovsky Cc: linux-rdma , Jason Gunthorpe Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Feb 12, 2020 at 11:25 PM Leon Romanovsky wrote: > > On Mon, Feb 10, 2020 at 12:17:45PM -0500, Devesh Sharma wrote: > > It becomes difficult to make out from the output of ibv_devinfo > > if a particular gid index is RoCE v2 or not. > > > > Adding a string to the output of ibv_devinfo -v to display the > > gid type at the end of gid. > > > > The output would look something like below: > > $ ibv_devinfo -v -d bnxt_re2 > > hca_id: bnxt_re2 > > transport: InfiniBand (0) > > fw_ver: 216.0.220.0 > > node_guid: b226:28ff:fed3:b0f0 > > sys_image_guid: b226:28ff:fed3:b0f0 > > . > > . > > . > > . > > phys_state: LINK_UP (5) > > GID[ 0]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, RoCE v1 > > GID[ 1]: fe80::b226:28ff:fed3:b0f0, RoCE v2 > > GID[ 2]: 0000:0000:0000:0000:0000:ffff:c0aa:0165, RoCE v1 > > GID[ 3]: ::ffff:192.170.1.101, RoCE v2 > > $ > > $ > > $ > > > > Reviewed-by: Jason Gunthrope > > Reviewed-by: Gal Pressman > > Reviewed-by: Parav Pandit > > Signed-off-by: Devesh Sharma > > --- > > libibverbs/examples/devinfo.c | 61 ++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 49 insertions(+), 12 deletions(-) > > > > Devesh, > > I see that everyone is happy now, can you please refresh PR so I will > merge it? > > Thanks, > Reviewed-by: Leon Romanovsky Done Thanks!