From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-rc 0/3] Broadcom's roce dirver bug fixes
Date: Wed, 20 Nov 2019 21:47:55 +0530 [thread overview]
Message-ID: <CANjDDBiMuL9Sj778=fKWsHPVXOxuemOWG+P-Xg+fDeDtDDqcPw@mail.gmail.com> (raw)
In-Reply-To: <20191120133219.GB22466@mellanox.com>
On Wed, Nov 20, 2019 at 7:02 PM Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> On Wed, Nov 20, 2019 at 10:52:01AM +0530, Devesh Sharma wrote:
> > On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <jgg@mellanox.com> wrote:
> > >
> > > On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote:
> > > > This series contain 3 patches patch 1 and patch 2 are specific to
> > > > Gen P5 devices. Patch 3 is a generic fix to silence few sparse
> > > > warnings.
> > >
> > > These commit messages are not suitable for -rc, and a sparse warning
> > > fix is rarely appropriate
> > >
> > > You need to describe what the user impact is of these bugs.
> > >
> > > -rc is done anyhow unless something urgent comes up.
> > Got your point. Let's drop sparse fixes patch from this series.
>
> Why? it can go to -next, like I said, there won't be another -rc
Yup, it can certainly go.
>
> > For first patch the impact catastrophic as consumer wont be able to use the
> > cards as it won't be listed the dev_list.
>
> Supporting a new card is a new feature, not -rc material
Alright, I shall move the series to for-next and add back the sparse
warning fix. Please ignore V2 which have posted already.
>
> Jason
prev parent reply other threads:[~2019-11-20 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 15:48 [PATCH for-rc 0/3] Broadcom's roce dirver bug fixes Devesh Sharma
2019-11-19 15:48 ` [PATCH for-rc 1/3] RDMA/bnxt_re: Fix chip number validation Broadcom's Gen P5 series Devesh Sharma
2019-11-19 15:48 ` [PATCH for-rc 2/3] RDMA/bnxt_re: fix stat push into dma buffer on gen p5 devices Devesh Sharma
2019-11-19 15:48 ` [PATCH for-rc 3/3] RDMA/bnxt_re: fix sparse warnings Devesh Sharma
2019-11-19 19:38 ` [PATCH for-rc 0/3] Broadcom's roce dirver bug fixes Jason Gunthorpe
2019-11-20 5:22 ` Devesh Sharma
2019-11-20 13:32 ` Jason Gunthorpe
2019-11-20 16:17 ` Devesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANjDDBiMuL9Sj778=fKWsHPVXOxuemOWG+P-Xg+fDeDtDDqcPw@mail.gmail.com' \
--to=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).