From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH for-next 0/7] Refactor control path of bnxt_re driver
Date: Mon, 27 Jan 2020 13:09:57 +0530 [thread overview]
Message-ID: <CANjDDBjfNaBgxVTWysF8aDfcT+4ROaDunnF7910m6m21h6ua-A@mail.gmail.com> (raw)
In-Reply-To: <20200125180355.GE4616@mellanox.com>
On Sat, Jan 25, 2020 at 11:34 PM Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> On Fri, Jan 24, 2020 at 12:52:38AM -0500, Devesh Sharma wrote:
> > This is the first series out of few more forthcoming series to refactor
> > Broadcom's RoCE driver. This series contains patches to refactor control
> > path. Since this is first series, there may be few code section which may
> > look redundant or overkill but those will be taken care in future patche
> > series.
> >
> > These patches apply clean on tip of for-next branch.
> > Each patch in this series is tested against user and kernel functionality.
> >
> > Devesh Sharma (7):
> > RDMA/bnxt_re: Refactor queue pair creation code
> > RDMA/bnxt_re: Replace chip context structure with pointer
> > RDMA/bnxt_re: Refactor hardware queue memory allocation
> > RDMA/bnxt_re: Refactor net ring allocation function
> > RDMA/bnxt_re: Refactor command queue management code
> > RDMA/bnxt_re: Refactor notification queue management code
> > RDMA/bnxt_re: Refactor doorbell management functions
> >
> > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 24 +-
> > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 670 +++++++++++++++++++----------
> > drivers/infiniband/hw/bnxt_re/main.c | 134 +++---
> > drivers/infiniband/hw/bnxt_re/qplib_fp.c | 423 +++++++++---------
> > drivers/infiniband/hw/bnxt_re/qplib_fp.h | 94 ++--
> > drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 474 ++++++++++++--------
> > drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 85 ++--
> > drivers/infiniband/hw/bnxt_re/qplib_res.c | 475 ++++++++++++--------
> > drivers/infiniband/hw/bnxt_re/qplib_res.h | 145 ++++++-
> > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 52 ++-
> > 10 files changed, 1579 insertions(+), 997 deletions(-)
>
> Usually when you 'refactor' something the code gets smaller, not
> larger. What is going on here?
I agree with this fact however this series is adding object attribute
structures at various places and the attribute initialization before
object creation is adding up code lines.
>
> Jason
prev parent reply other threads:[~2020-01-27 7:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 5:52 [PATCH for-next 0/7] Refactor control path of bnxt_re driver Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code Devesh Sharma
2020-01-24 11:23 ` Leon Romanovsky
2020-01-25 17:03 ` Devesh Sharma
2020-01-25 18:50 ` Leon Romanovsky
2020-01-27 7:39 ` Devesh Sharma
2020-01-30 6:04 ` Devesh Sharma
2020-01-25 17:46 ` Jason Gunthorpe
2020-01-27 8:13 ` Devesh Sharma
2020-01-27 8:16 ` Devesh Sharma
2020-01-27 9:27 ` Leon Romanovsky
2020-01-27 9:26 ` Leon Romanovsky
2020-01-27 11:31 ` Devesh Sharma
2020-01-30 6:04 ` Devesh Sharma
2020-01-30 13:37 ` Parav Pandit
2020-01-30 16:03 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 2/7] RDMA/bnxt_re: Replace chip context structure with pointer Devesh Sharma
2020-01-25 18:03 ` Jason Gunthorpe
2020-01-27 7:39 ` Devesh Sharma
2020-01-27 8:04 ` Leon Romanovsky
2020-01-27 11:17 ` Devesh Sharma
2020-01-28 20:15 ` Jason Gunthorpe
2020-01-30 6:05 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 3/7] RDMA/bnxt_re: Refactor hardware queue memory allocation Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 4/7] RDMA/bnxt_re: Refactor net ring allocation function Devesh Sharma
2020-01-26 14:29 ` Leon Romanovsky
2020-01-27 7:40 ` Devesh Sharma
2020-01-27 8:02 ` Leon Romanovsky
2020-01-27 11:25 ` Devesh Sharma
2020-01-27 12:44 ` Leon Romanovsky
2020-01-27 14:14 ` Devesh Sharma
2020-01-28 18:09 ` Jason Gunthorpe
2020-01-28 0:35 ` Jason Gunthorpe
2020-01-28 2:43 ` Devesh Sharma
2020-01-28 18:09 ` Jason Gunthorpe
2020-01-29 8:29 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 5/7] RDMA/bnxt_re: Refactor command queue management code Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 6/7] RDMA/bnxt_re: Refactor notification " Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 7/7] RDMA/bnxt_re: Refactor doorbell management functions Devesh Sharma
2020-01-25 18:04 ` [PATCH for-next 0/7] Refactor control path of bnxt_re driver Jason Gunthorpe
2020-01-27 7:39 ` Devesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANjDDBjfNaBgxVTWysF8aDfcT+4ROaDunnF7910m6m21h6ua-A@mail.gmail.com \
--to=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).