From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C0A2C2D0DB for ; Wed, 22 Jan 2020 16:36:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DF7A21835 for ; Wed, 22 Jan 2020 16:36:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="Z4L3hfli" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbgAVQgn (ORCPT ); Wed, 22 Jan 2020 11:36:43 -0500 Received: from mail-il1-f196.google.com ([209.85.166.196]:43427 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbgAVQgn (ORCPT ); Wed, 22 Jan 2020 11:36:43 -0500 Received: by mail-il1-f196.google.com with SMTP id v69so5593659ili.10 for ; Wed, 22 Jan 2020 08:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K9FK8ILS4gKEGyvvYVDTxyD1X36SRBkx7WZjPTcSEcs=; b=Z4L3hfliSUQrUzbrj1MlCEkPPFxOpnSbzpAFcwm7qeWX4e/pbbIKKl209hP+fISEnP vmVHrOvykodYtrqi2vT3bv7pJiPqyBZ4bO45dftH0rj0+1VZj+L9Umq4BlCP+rNOXfSt Ux/NJVyDycljikm6ED400Wi05ogQbRJkkITNZA+wbYQbIcUVZsxKI+JoUDi3qEERB1fw p5e4a2hLYkRgLpOi5xhS+1sdSlyDYJeoYxh3dQzC+CAmhwVlEJDXqxJEs8Y/Wn+WvHus fLXyX1KKqSxHHgSSEMoTPwIQ5Jpqxn4nMYI8q4ihvpw74thK6KX+clWCLXmZKGhr5hkb 3BLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K9FK8ILS4gKEGyvvYVDTxyD1X36SRBkx7WZjPTcSEcs=; b=LVcQvzipe1kcVW+qb8JtNRrImDiBsH6NluDVXK0IQ7zeDTXKadCTyxyGBfGI1Dkk24 4eTAAINPzSnBtFoWuWghvh3Z2E6sHT+zLKpQ0UGIhmPgKwR3Q1hZQ/RJid1loP2+UpLW 8XTW+r2Y4OdpnSZ1Xmwc0rEEYk+nPxNEhEFhC8HKi0z2Ebt4QXnbInx07wCLmVTOf+rC R5LkaEnX8zJByszDyxwR7mu9E6QmH72vz+wnAVyOj4TfLJttzpLxz7shTt4Z07da8wRL tVtlfNJN+EubE2R6OpNrSH2CscS9w+lUwqScs7RH+ad0cFBlBxtcEX95x8iYTLI9qNoR bAWw== X-Gm-Message-State: APjAAAVW1EHd2nUeuuZibc9NJcY/XlVoVD36kOq+FLQep9I6wMHeBVpe NQfyrcoj5yQm9299rEf/R0Uj+lJ2KfKkL4COkFy0fejq X-Google-Smtp-Source: APXvYqwedMrTFJR7YUejP+7khV4HmZtJkv4f0XHaUeXhywVWfDRT2A/C5vTr++prJAvCa1vkPR7LStortsglGNfTrDQ= X-Received: by 2002:a92:afc5:: with SMTP id v66mr8200600ill.123.1579711002748; Wed, 22 Jan 2020 08:36:42 -0800 (PST) MIME-Version: 1.0 References: <20191220001517.105297-1-olof@lixom.net> <028a4905eaf02dce476e8cfc517b49760f57f577.camel@mellanox.com> In-Reply-To: <028a4905eaf02dce476e8cfc517b49760f57f577.camel@mellanox.com> From: Olof Johansson Date: Wed, 22 Jan 2020 08:36:31 -0800 Message-ID: Subject: Re: [PATCH] net/mlx5e: Fix printk format warning To: Saeed Mahameed Cc: "saeedm@dev.mellanox.co.il" , "joe@perches.com" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "leon@kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jan 21, 2020 at 12:43 PM Saeed Mahameed wrote: > > On Mon, 2020-01-20 at 19:20 -0800, Olof Johansson wrote: > > Hi, > > > > On Mon, Dec 30, 2019 at 8:35 PM Saeed Mahameed > > wrote: > > > On Sat, Dec 21, 2019 at 1:19 PM Olof Johansson > > > wrote: > > > > On Thu, Dec 19, 2019 at 6:07 PM Joe Perches > > > > wrote: > > > > > On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote: > > > > > > Use "%zu" for size_t. Seen on ARM allmodconfig: > > > > > [] > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c > > > > > > b/drivers/net/ethernet/mellanox/mlx5/core/wq.c > > > > > [] > > > > > > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct > > > > > > mlx5_wq_cyc *wq, u16 ix, u8 nstrides) > > > > > > len = nstrides << wq->fbc.log_stride; > > > > > > wqe = mlx5_wq_cyc_get_wqe(wq, ix); > > > > > > > > > > > > - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index > > > > > > 0x%x, len: %ld\n", > > > > > > + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index > > > > > > 0x%x, len: %zu\n", > > > > > > mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len); > > > > > > print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, > > > > > > 16, 1, wqe, len, false); > > > > > > } > > > > > > > > > > One might expect these 2 outputs to be at the same KERN_ > > > > > too. > > > > > One is KERN_INFO the other KERN_WARNING > > > > > > > > Sure, but I'll leave that up to the driver maintainers to > > > > decide/fix > > > > -- I'm just addressing the type warning here. > > > > > > Hi Olof, sorry for the delay, and thanks for the patch, > > > > > > I will apply this to net-next-mlx5 and will submit to net-next > > > myself. > > > we will fixup and address the warning level comment by Joe. > > > > This seems to still be pending, and the merge window is soon here. > > Any > > chance we can see it show up in linux-next soon? > > > > > > Hi Olof, > > I am still preparing my next pull request which will include this patch > I will send it soon to net-next branch, but still the patch will not > hit linux-next until the merge window when netdev subsystem is pulled > into linux-next.. Hi Saeed, linux-next contains all the material that maintainers are queuing up for the next merge window, during the -rc cycles of the previous release, including the net-next branch. In general, the guideline is to make sure that most patches are in -next around -rc6/rc7 timeframe, to give them some time for test before merge window opens. So the fact that this hasn't been picked up and showed up there yet, seems concerning -- but I don't know when Dave closes net for new material like what you're staging. -Olof