From: Dan Williams <dan.j.williams@intel.com>
To: "Ertman, David M" <david.m.ertman@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
Netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
Parav Pandit <parav@mellanox.com>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Patil, Kiran" <kiran.patil@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH v3 01/10] Add auxiliary bus support
Date: Thu, 5 Nov 2020 14:00:00 -0800 [thread overview]
Message-ID: <CAPcyv4hjCmaCEUhgchkJO7WaGQeTz8gtS2YgMtBAvoGBksvvSg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB284191BAA817540E52E4E2C4DDEE0@DM6PR11MB2841.namprd11.prod.outlook.com>
On Thu, Nov 5, 2020 at 11:28 AM Ertman, David M
<david.m.ertman@intel.com> wrote:
[..]
> > > Each auxiliary_device represents a part of its parent
> > > +functionality. The generic behavior can be extended and specialized as
> > needed
> > > +by encapsulating an auxiliary_device within other domain-specific
> > structures and
> > > +the use of .ops callbacks. Devices on the auxiliary bus do not share any
> > > +structures and the use of a communication channel with the parent is
> > > +domain-specific.
> >
> > Should there be any guidance here on when to use ops and when to just
> > export functions from parent driver to child. EXPORT_SYMBOL_NS() seems
> > a perfect fit for publishing shared routines between parent and child.
> >
>
> I would leave this up the driver writers to determine what is best for them.
I think there is a pathological case that can be avoided with a
statement like the following:
"Note that ops are intended as a way to augment instance behavior
within a class of auxiliary devices, it is not the mechanism for
exporting common infrastructure from the parent. Consider
EXPORT_SYMBOL_NS() to convey infrastructure from the parent module to
the auxiliary module(s)."
As for your other dispositions of the feedback, looks good to me.
next prev parent reply other threads:[~2020-11-05 22:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 0:33 [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Dave Ertman
2020-10-23 0:33 ` [PATCH v3 01/10] Add auxiliary bus support Dave Ertman
2020-11-05 9:19 ` Dan Williams
2020-11-05 9:47 ` Leon Romanovsky
2020-11-05 17:12 ` Dan Williams
2020-11-05 19:30 ` Leon Romanovsky
2020-11-05 20:27 ` Dan Williams
2020-11-05 20:22 ` Greg KH
2020-11-05 20:24 ` Dan Williams
2020-11-05 19:27 ` Ertman, David M
2020-11-05 19:32 ` Pierre-Louis Bossart
2020-11-05 19:37 ` Leon Romanovsky
2020-11-05 19:35 ` Leon Romanovsky
2020-11-05 20:52 ` Ertman, David M
2020-11-05 19:40 ` Parav Pandit
2020-11-05 20:26 ` Dan Williams
2020-11-05 20:37 ` Parav Pandit
2020-11-06 19:35 ` Mark Brown
2020-11-10 7:23 ` Oded Gabbay
2020-11-05 22:00 ` Dan Williams [this message]
2020-11-05 23:48 ` Ertman, David M
2020-11-13 15:50 ` Greg KH
2020-11-13 16:07 ` Ertman, David M
2020-11-13 23:21 ` Greg KH
2020-11-15 6:48 ` Leon Romanovsky
2020-10-23 0:33 ` [PATCH v3 02/10] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman
2020-10-23 0:33 ` [PATCH v3 03/10] ASoC: SOF: Create client driver for IPC test Dave Ertman
2020-10-23 0:33 ` [PATCH v3 04/10] ASoC: SOF: ops: Add ops for client registration Dave Ertman
2020-10-23 0:33 ` [PATCH v3 05/10] ASoC: SOF: Intel: Define " Dave Ertman
2020-10-23 0:33 ` [PATCH v3 06/10] ASoC: SOF: Intel: Remove IPC flood test support in SOF core Dave Ertman
2020-10-23 0:33 ` [PATCH v3 07/10] ASoC: SOF: sof-client: Add client APIs to access probes ops Dave Ertman
2020-10-23 0:33 ` [PATCH v3 08/10] ASoC: SOF: compress: move and export sof_probe_compr_ops Dave Ertman
2020-10-23 0:33 ` [PATCH v3 09/10] ASoC: SOF: Add new client driver for probes support Dave Ertman
2020-10-23 0:33 ` [PATCH v3 10/10] ASoC: SOF: Intel: CNL: register probes client Dave Ertman
2020-10-23 6:49 ` [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support Leon Romanovsky
2020-10-23 6:56 ` Greg KH
2020-10-23 15:48 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hjCmaCEUhgchkJO7WaGQeTz8gtS2YgMtBAvoGBksvvSg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=fred.oh@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shiraz.saleem@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).