From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81DCCC5517A for ; Thu, 5 Nov 2020 17:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20F93206F9 for ; Thu, 5 Nov 2020 17:13:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="LrZHWpUi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730382AbgKERNG (ORCPT ); Thu, 5 Nov 2020 12:13:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728523AbgKERNG (ORCPT ); Thu, 5 Nov 2020 12:13:06 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B3D3C0613D3 for ; Thu, 5 Nov 2020 09:13:05 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id o18so2343593edq.4 for ; Thu, 05 Nov 2020 09:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1OVEId5NbPuZhwiD2RAxt7P3TFnewmmafINvYAxM9CY=; b=LrZHWpUiBijvD4dqiTIysN1yWqAONqYpkr1vF2nMOS+hzduZIeM9hIf9ooQe26IE8x Zmen5HnkiRYPdRkczOgG7PHViRULQgRSh24HzkkD8TnlHfrOHC4X8yhXpNpNG/ORWYm+ 8wzyGEQEYw5xzt1fv37sZ7AzR4NgvrT5AI/st4t6GIPGqYX4ujx5Od/iswmS/n1ZkGFi 8ArvQwe1MlI/iMZPOw7fltm7snk1o3RERYoVlgdlK3w0d6tT17fuPenDn1EL1jlT7c7c xPw0cBd21Pvskls1uPUF/wiUX/ZxaGdUHaYJf0LBuCctPWOozxR9FnzbhilazLwlxX+o 3kUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1OVEId5NbPuZhwiD2RAxt7P3TFnewmmafINvYAxM9CY=; b=kY0y1FwXLHOKUG5KEBym6dO0WqvhgLCE2mHEvRzkPio6CiU+sGqcdQjtoKkaZ+34cT 3AoVBTLd99vwEoovh7AADuPZT94pymqv+iAg6kzay0icc51g8Vu5Hj6OA8czmvaP7lbb xAYIJV3UoizIIijJtpaGAQh0eQr1k18MiKEA1xb1r7rRReT1uVPRabCUySGh/2+kpJEF j/qdvD29p7+y14UDdVqLOE/bqt4pKzshyozuXkYMliTbheX1k/VqtGgJAp1Lrl8c1iua nbxcAzj5NJtQmh0IGRXytzSlC3QYZZQpUaKaSIqqKtCLT+3pu2n8udUlwkxD7hWDHOQC dayw== X-Gm-Message-State: AOAM532TlyJ9Sz70r+Bn2+l0Aa/ggGahC9RfZ7dlWM8rNbp2erqx6GX1 dqlTqeAf8F94lRPu4obKR3uHgedeYtwNeGwRPjA/Hw== X-Google-Smtp-Source: ABdhPJxR0K2Ny/la8w6wudT2r17AxOkb0bU7Tr0zLMl7ek9oU/t/pYtRlPYcNtxXSTQpX0bbGX3l0C3ZdfAY3A/HaRk= X-Received: by 2002:aa7:d843:: with SMTP id f3mr3709824eds.354.1604596382315; Thu, 05 Nov 2020 09:13:02 -0800 (PST) MIME-Version: 1.0 References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> <20201105094719.GQ5429@unreal> In-Reply-To: <20201105094719.GQ5429@unreal> From: Dan Williams Date: Thu, 5 Nov 2020 09:12:51 -0800 Message-ID: Subject: Re: [PATCH v3 01/10] Add auxiliary bus support To: Leon Romanovsky Cc: Dave Ertman , alsa-devel@alsa-project.org, Takashi Iwai , Mark Brown , linux-rdma , Jason Gunthorpe , Doug Ledford , Netdev , David Miller , Jakub Kicinski , Greg KH , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , Parav Pandit , "Saleem, Shiraz" , "Patil, Kiran" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > > > > <...> > > > > > > > +config AUXILIARY_BUS > > > + bool > > > > tristate? Unless you need non-exported symbols, might as well let this > > be a module. > > I asked it to be "bool", because bus as a module is an invitation for > a disaster. For example if I compile-in mlx5 which is based on this bus, > and won't add auxiliary_bus as a module to initramfs, the system won't boot. Something is broken if module dependencies don't arrange for auxiliary_bus.ko to be added to the initramfs automatically, but yes, it is another degree of freedom for something to go wrong if you build the initramfs by hand. > > <...> > > > > > Per above SPDX is v2 only, so... > > Isn't it default for the Linux kernel? SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") implies the "or later" language. The only default assumption is that the license is GPL v2 compatible, those possibilities are myriad, but v2-only is the first preference.