From: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To: Haakon Bugge <haakon.bugge@oracle.com>
Cc: Chuck Lever III <chuck.lever@oracle.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Doug Ledford <dledford@redhat.com>
Subject: RE: NFS RDMA test failure as of 5.14-rc1
Date: Tue, 27 Jul 2021 17:14:46 +0000 [thread overview]
Message-ID: <CH0PR01MB7153166CD64AE0097B72608CF2E99@CH0PR01MB7153.prod.exchangelabs.com> (raw)
In-Reply-To: <CH0PR01MB7153D5381BBC3D1D0F146E8AF2E99@CH0PR01MB7153.prod.exchangelabs.com>
.
>
> I suspect the patch needs to be reverted or NFS RDMA needs to handle the
> transition to INIT?
>
Reverting the patch below works.
> commit dc70f7c3ed34b081c02a611591c5079c53b771b8
> Author: H�kon Bugge <haakon.bugge@oracle.com>
> Date: Tue Jun 22 15:39:56 2021 +0200
>
> RDMA/cma: Remove unnecessary INIT->INIT transition
A quick audit of .post_recv calls:
1 main.c <global> 698 .post_recv = bnxt_re_post_recv, <-- allows
2 provider.c <global> 489 .post_recv = c4iw_post_receive, <-- allows
3 hns_roce_hw_v1.c <global> 4411 .post_recv = hns_roce_v1_post_recv, <-- allows
4 hns_roce_hw_v2.c <global> 6190 .post_recv = hns_roce_v2_post_recv, <-- -EINVAL
5 verbs.c <global> 4396 .post_recv = irdma_post_recv, <-- allows
6 main.c <global> 2561 .post_recv = mlx4_ib_post_recv, <-- allows
7 main.c <global> 3767 .post_recv = mlx5_ib_post_recv_nodrain, <-- allows
8 mthca_provider.c <global> 1148 .post_recv = mthca_arbel_post_receive, <-- allows
9 mthca_provider.c <global> 1154 .post_recv = mthca_tavor_post_receive, <-- allows
a ocrdma_main.c <global> 173 .post_recv = ocrdma_post_recv, <-- -EINVAL
b main.c <global> 221 .post_recv = qedr_post_recv, <- -EINVAL
c pvrdma_main.c <global> 175 .post_recv = pvrdma_post_recv, <- -EINVAL
d vt.c <global> 392 .post_recv = rvt_post_recv,<- -EINVAL
e rxe_verbs.c <global> 1132 .post_recv = rxe_post_recv, <- -EINVAL
f siw_main.c <global> 287 .post_recv = siw_post_receive, <-- allows?
Looks like it is a non-portable assumption that an out-of-state post recv works. I guess it is possible that the post happens and gets flushed back?
From the IBTA spec:
Reset to Init - Enable posting to the Receive Queue
... post receive notes "Invalid QP state" as a possible immediate failure, but nothing more binding than that.
Mike
next prev parent reply other threads:[~2021-07-27 17:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 13:43 NFS RDMA test failure as of 5.14-rc1 Marciniszyn, Mike
2021-07-27 17:14 ` Marciniszyn, Mike [this message]
2021-07-27 17:26 ` Chuck Lever III
2021-07-27 17:35 ` Marciniszyn, Mike
2021-07-27 17:38 ` Jason Gunthorpe
2021-07-27 17:45 ` Chuck Lever III
2021-07-27 21:20 ` Marciniszyn, Mike
2021-07-27 23:10 ` Chuck Lever III
2021-07-28 4:31 ` Leon Romanovsky
2021-07-27 18:12 ` Leon Romanovsky
2021-07-27 20:17 ` Marciniszyn, Mike
2021-07-28 13:50 ` Marciniszyn, Mike
2021-07-28 17:05 ` Jason Gunthorpe
2021-07-29 18:28 ` Marciniszyn, Mike
2021-08-09 13:38 ` Haakon Bugge
2021-08-09 14:00 ` Chuck Lever III
2021-08-10 15:09 ` Marciniszyn, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR01MB7153166CD64AE0097B72608CF2E99@CH0PR01MB7153.prod.exchangelabs.com \
--to=mike.marciniszyn@cornelisnetworks.com \
--cc=chuck.lever@oracle.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).