From: <Steen.Hegelund@microchip.com>
To: <jiapeng.chong@linux.alibaba.com>, <saeedm@nvidia.com>
Cc: <leon@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<abaci@linux.alibaba.com>
Subject: Re: [PATCH 1/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover()
Date: Fri, 24 Mar 2023 12:16:41 +0000 [thread overview]
Message-ID: <CRELUJ25CXTV.2GTO7Z4RFDSDU@den-dk-m31857> (raw)
In-Reply-To: <20230324025541.38458-1-jiapeng.chong@linux.alibaba.com>
Hi Jiapeng,
Looks good to me.
On Fri Mar 24, 2023 at 3:55 AM CET, Jiapeng Chong wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
>
> drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c:104 mlx5e_rx_reporter_err_icosq_cqe_recover() warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4601
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> index b621f735cdc3..b66183204be3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c
> @@ -100,8 +100,10 @@ static int mlx5e_rx_reporter_err_icosq_cqe_recover(void *ctx)
> goto out;
> }
>
> - if (state != MLX5_SQC_STATE_ERR)
> + if (state != MLX5_SQC_STATE_ERR) {
> + err = -EINVAL;
> goto out;
> + }
>
> mlx5e_deactivate_rq(rq);
> if (xskrq)
> --
> 2.20.1.7.g153144c
Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
BR
Steen
next prev parent reply other threads:[~2023-03-24 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 2:55 [PATCH 1/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover() Jiapeng Chong
2023-03-24 2:55 ` [PATCH 2/2] " Jiapeng Chong
2023-03-24 12:17 ` Steen.Hegelund
2023-03-29 10:32 ` Leon Romanovsky
2023-03-24 12:16 ` Steen.Hegelund [this message]
2023-03-29 10:31 ` [PATCH 1/2] " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRELUJ25CXTV.2GTO7Z4RFDSDU@den-dk-m31857 \
--to=steen.hegelund@microchip.com \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).