linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [PATCH] irdma: Add ice and irdma to kernel-boot rules
Date: Thu, 12 Aug 2021 23:33:04 +0000	[thread overview]
Message-ID: <DM6PR11MB4692C424F3B5AB513B0EBBDACBF99@DM6PR11MB4692.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210806182852.GS1721383@nvidia.com>



> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Friday, August 6, 2021 1:29 PM
> To: Nikolova, Tatyana E <tatyana.e.nikolova@intel.com>
> Cc: dledford@redhat.com; leon@kernel.org; linux-rdma@vger.kernel.org
> Subject: Re: [PATCH] irdma: Add ice and irdma to kernel-boot rules
> 
> On Fri, Aug 06, 2021 at 12:58:08PM -0500, Tatyana Nikolova wrote:
> > Add ice and irdma to kernel-boot rules so that these devices are
> > recognized as iWARP and RoCE capable.
> >
> > Otherwise the port mapper service which is only relevant for iWARP
> > devices may not start automatically after boot.
> >
> > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
> > kernel-boot/rdma-description.rules | 2 ++
> > kernel-boot/rdma-hw-modules.rules  | 1 +
> >  2 files changed, 3 insertions(+)
> >
> > diff --git a/kernel-boot/rdma-description.rules
> > b/kernel-boot/rdma-description.rules
> > index 48a7ced..f2f7b38 100644
> > +++ b/kernel-boot/rdma-description.rules
> > @@ -24,11 +24,13 @@ DRIVERS=="hfi1", ENV{ID_RDMA_OPA}="1"
> >  # Hardware that supports iWarp
> >  DRIVERS=="cxgb4", ENV{ID_RDMA_IWARP}="1"
> >  DRIVERS=="i40e", ENV{ID_RDMA_IWARP}="1"
> > +DRIVERS=="ice", ENV{ID_RDMA_IWARP}="1"
> >
> >  # Hardware that supports RoCE
> >  DRIVERS=="be2net", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="bnxt_en", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="hns", ENV{ID_RDMA_ROCE}="1"
> > +DRIVERS=="ice", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="mlx4_core", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="mlx5_core", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="qede", ENV{ID_RDMA_ROCE}="1"
> > diff --git a/kernel-boot/rdma-hw-modules.rules
> > b/kernel-boot/rdma-hw-modules.rules
> > index 95eaf72..040deb3 100644
> > +++ b/kernel-boot/rdma-hw-modules.rules
> > @@ -12,6 +12,7 @@ ENV{ID_NET_DRIVER}=="bnxt_en",
> RUN{builtin}+="kmod load bnxt_re"
> >  ENV{ID_NET_DRIVER}=="cxgb4", RUN{builtin}+="kmod load iw_cxgb4"
> >  ENV{ID_NET_DRIVER}=="hns", RUN{builtin}+="kmod load hns_roce"
> >  ENV{ID_NET_DRIVER}=="i40e", RUN{builtin}+="kmod load i40iw"
> > +ENV{ID_NET_DRIVER}=="ice", RUN{builtin}+="kmod load irdma"
> 
> This should not be needed, right? The auxbux stuff triggers proper module
> autoloading?

Hi Jason,

Our module depends on the auxbus, but we don't know how the auxbus could trigger loading of irdma. Could you please explain? 
 
Thank you,
Tatyana

  reply	other threads:[~2021-08-12 23:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 17:58 [PATCH] irdma: Add ice and irdma to kernel-boot rules Tatyana Nikolova
2021-08-06 18:28 ` Jason Gunthorpe
2021-08-12 23:33   ` Nikolova, Tatyana E [this message]
2021-08-18 16:45     ` Jason Gunthorpe
2021-08-20 21:46       ` Nikolova, Tatyana E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4692C424F3B5AB513B0EBBDACBF99@DM6PR11MB4692.namprd11.prod.outlook.com \
    --to=tatyana.e.nikolova@intel.com \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).