linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kalderon <mkalderon@marvell.com>
To: Kamal Heib <kamalheib1@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	"Ariel Elior" <aelior@marvell.com>
Subject: RE: [EXT] [PATCH for-rc] RDMA/qedr: Fix reported firmware version
Date: Thu, 10 Oct 2019 08:46:41 +0000	[thread overview]
Message-ID: <MN2PR18MB31828906894A5723E5A18F87A1940@MN2PR18MB3182.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20191007210730.7173-1-kamalheib1@gmail.com>

> From: Kamal Heib <kamalheib1@gmail.com>
> Sent: Tuesday, October 8, 2019 12:08 AM
> 
> External Email
> 
> ----------------------------------------------------------------------
> Remove spaces from the reported firmware version string.
> Actual value:
> $ cat /sys/class/infiniband/qedr0/fw_ver
> 8. 37. 7. 0
> 
> Expected value:
> $ cat /sys/class/infiniband/qedr0/fw_ver
> 8.37.7.0
> 
> Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/hw/qedr/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/main.c
> b/drivers/infiniband/hw/qedr/main.c
> index 5136b835e1ba..dc71b6e16a07 100644
> --- a/drivers/infiniband/hw/qedr/main.c
> +++ b/drivers/infiniband/hw/qedr/main.c
> @@ -76,7 +76,7 @@ static void qedr_get_dev_fw_str(struct ib_device
> *ibdev, char *str)
>  	struct qedr_dev *qedr = get_qedr_dev(ibdev);
>  	u32 fw_ver = (u32)qedr->attr.fw_ver;
> 
> -	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d. %d. %d. %d",
> +	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d.%d.%d.%d",
>  		 (fw_ver >> 24) & 0xFF, (fw_ver >> 16) & 0xFF,
>  		 (fw_ver >> 8) & 0xFF, fw_ver & 0xFF);  }
> --
> 2.20.1

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@marvell.com>



  reply	other threads:[~2019-10-10  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 21:07 [PATCH for-rc] RDMA/qedr: Fix reported firmware version Kamal Heib
2019-10-10  8:46 ` Michal Kalderon [this message]
2019-10-18 18:52 ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR18MB31828906894A5723E5A18F87A1940@MN2PR18MB3182.namprd18.prod.outlook.com \
    --to=mkalderon@marvell.com \
    --cc=aelior@marvell.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kamalheib1@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).