linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: rama nichanamatlu <rama.nichanamatlu@oracle.com>
Cc: Rohit Nair <rohit.sajan.kumar@oracle.com>,
	jgg@ziepe.ca, saeedm@nvidia.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, manjunath.b.patil@oracle.com,
	Michael Guralnik <michaelgur@nvidia.com>
Subject: Re: [External] : Re: [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs
Date: Wed, 9 Nov 2022 20:33:24 +0200	[thread overview]
Message-ID: <Y2vydHwL3waJeaHw@unreal> (raw)
In-Reply-To: <f3a56720-4df4-6b17-bfdf-4385dc27a2c0@oracle.com>

On Tue, Nov 08, 2022 at 04:24:48PM -0600, rama nichanamatlu wrote:
> in-line.

<...>

> > The thing is that "vendor" failed to explain internally if this debug
> > code is useful. Like I said, extremely rare debug code shouldn't be part
> > of main data path.
> > 
> > Thanks
> 
> thank you very much for you insights into the relevance of the patch. before
> we close this topic, do want to ask on this.  what is the expectation of the
> nic hardware when it signatures / checksum's an eqe or cqe ?
> 
> if it not to be verified by the receiver host for what ever reasons, then
> why even do the checksum computation on the hardware ? 

mlx5 data sheet has more than 3000 pages in it. Not everything there is needed now.

Thanks

      parent reply	other threads:[~2022-11-09 18:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 17:45 [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs Rohit Nair
2022-10-11  7:17 ` Leon Romanovsky
2022-10-25 17:44   ` [External] : " Rohit Nair
2022-10-27 12:23     ` Leon Romanovsky
2022-10-28 23:48       ` Rohit Nair
2022-11-06 18:03         ` Leon Romanovsky
2022-11-07 17:51           ` Rohit Nair
     [not found]           ` <f3a56720-4df4-6b17-bfdf-4385dc27a2c0@oracle.com>
2022-11-09 18:33             ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2vydHwL3waJeaHw@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=manjunath.b.patil@oracle.com \
    --cc=michaelgur@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rama.nichanamatlu@oracle.com \
    --cc=rohit.sajan.kumar@oracle.com \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).