From: Leon Romanovsky <leon@kernel.org>
To: Jinpu Wang <jinpu.wang@cloud.ionos.com>
Cc: Jack Wang <xjtuwjp@gmail.com>, Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Subject: Re: IPoIB child interfaces not working with mlx5
Date: Mon, 22 Mar 2021 08:56:49 +0200 [thread overview]
Message-ID: <YFg/sb+vnpIhyh1c@unreal> (raw)
In-Reply-To: <CAMGffEmwCrcF+J+=6cV1ND=K6rVm0DjdiO9J2bTxkh5c21oCpA@mail.gmail.com>
On Mon, Mar 22, 2021 at 07:08:01AM +0100, Jinpu Wang wrote:
> On Sun, Mar 21, 2021 at 2:07 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Sat, Mar 20, 2021 at 02:09:50PM +0100, Jack Wang wrote:
> > > Leon Romanovsky <leon@kernel.org>于2021年3月20日 周六12:17写道：
> > >
> > > > On Fri, Mar 19, 2021 at 08:44:29AM +0100, Jinpu Wang wrote:
> > > > > Hi Jason and Leon,
> > > > >
> > > > > We recently switch to use upstream OFED from MLNX-OFED, and we notice
> > > > > IPoIB stop working with upstream kernel 5.4.102 with mellanox CX-5
> > > > > HCA, it's working fine on CX-2/CX-3. I tested also on 5.11 kernel it
> > > > > behaves the same.
> > > >
> > > > Are you using "enhanced IPoIB" for CX-5 devices? MLX5_CORE_IPOIB?
> > > >
> > > > Thanks
> > >
> > > Yes.
> >
> > > Is this expected behavor?
> >
> > Yes, we wanted to make IPoIB behave like any other netdev interfaces and
> > if parent interface isn't enabled, no traffic should pass. More on that,
> > in our internal implementation of enhanced IPoIB, we are reusing same
> > resources for both parent and child, this requires us to wait for "UP"
> > event before allowing traffic.
> >
> > Thanks
> Hi Leon,
>
> Thanks for the clarification, is this behavior documented somewhere?
> is it specific to "enhanced IPoIB" for CX-5?
It is specific to "enhanced IPoIB" and not to device. I don't know where
we can document it.
> Will it work differently if without MLX5_CORE_IPOIB enabled?
Yes, without MLX5_CORE_IPOIB, the devices will work in "legacy IPoIB",
exactly as cx-3. The best thing will be to change IPoIB ULP to behave
like netdev, but we were not comfortable to do it back then due to
user visible nature of such change.
>
> I think it would be helpful to add a message if possible to remind
> admin to enable parent if only child if configured.
Care to send patch?
Thanks
>
> Thanks!
>
> >
> > >
> > > >
> > > >
next prev parent reply other threads:[~2021-03-22 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 7:44 IPoIB child interfaces not working with mlx5 Jinpu Wang
2021-03-20 9:30 ` Leon Romanovsky
[not found] ` <CAD+HZHUHbuBeoB4cCLc78gsmZAEyEr+fiWtpuTrxyzRBzMBf_g@mail.gmail.com>
2021-03-21 13:07 ` Leon Romanovsky
2021-03-22 6:08 ` Jinpu Wang
2021-03-22 6:56 ` Leon Romanovsky [this message]
2021-04-20 9:14 ` Jinpu Wang
2021-04-20 11:29 ` Leon Romanovsky
2021-05-07 6:53 ` Jinpu Wang
2021-05-07 8:03 ` Zhu Yanjun
2021-05-07 8:11 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFg/sb+vnpIhyh1c@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-rdma@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).