From: Leon Romanovsky <leon@kernel.org>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org,
dledford@redhat.com, jgg@ziepe.ca
Subject: Re: [PATCH v3] RDMA/ipoib: print a message if only child interface is UP
Date: Thu, 8 Apr 2021 12:48:28 +0300 [thread overview]
Message-ID: <YG7RbOo/N1TeoqJB@unreal> (raw)
In-Reply-To: <20210408093215.24023-1-jinpu.wang@ionos.com>
On Thu, Apr 08, 2021 at 11:32:15AM +0200, Jack Wang wrote:
> When "enhanced IPoIB" enabled for CX-5 devices, it requires
> the parent device to be UP, otherwise the child devices won't
> work.
>
> This add a debug message to give admin a hint, if only child interface
> is UP, but parent interface is not.
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index e16b40c09f82..df6329abac1d 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -164,8 +164,13 @@ int ipoib_open(struct net_device *dev)
> dev_change_flags(cpriv->dev, flags | IFF_UP, NULL);
> }
> up_read(&priv->vlan_rwsem);
> - }
> + } else if (priv->parent) {
> + struct ipoib_dev_priv *ppriv = ipoib_priv(priv->parent);
>
> + if (!test_bit(IPOIB_FLAG_ADMIN_UP, &ppriv->flags))
> + ipoib_dbg(priv, "parent device %s is not up, so child device may be not functioning.\n",
> + ppriv->dev->name);
I personally would use stronger language than that.
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Thanks
> + }
> netif_start_queue(dev);
>
> return 0;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-04-08 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 9:32 [PATCH v3] RDMA/ipoib: print a message if only child interface is UP Jack Wang
2021-04-08 9:48 ` Leon Romanovsky [this message]
2021-04-08 10:11 ` Jinpu Wang
2021-04-13 23:08 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG7RbOo/N1TeoqJB@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).