From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org,
Alexander Matushevsky <matua@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH for-next] RDMA/nldev: Add copy-on-fork attribute to get sys command
Date: Mon, 5 Apr 2021 14:58:37 +0300 [thread overview]
Message-ID: <YGr7bY9CcQoDXSb2@unreal> (raw)
In-Reply-To: <YGr7EajqXvSGyZfy@unreal>
On Mon, Apr 05, 2021 at 02:57:05PM +0300, Leon Romanovsky wrote:
> On Mon, Apr 05, 2021 at 02:47:21PM +0300, Gal Pressman wrote:
> > The new attribute indicates that the kernel copies DMA pages on fork,
> > hence libibverbs' fork support through madvise and MADV_DONTFORK is not
> > needed.
> >
> > The introduced attribute is always reported as supported since the
> > kernel has the patch that added the copy-on-fork behavior. This allows
> > the userspace library to identify older vs newer kernel versions.
> > Extra care should be taken when backporting this patch as it relies on
> > the fact that the copy-on-fork patch is merged, hence no check for
> > support is added.
>
> Please be more specific, add SHA-1 of that patch and wrote the same
> comment near "err = nla_put_u8(msg, RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK,
> 1);" line.
And rdmatool should be updated too.
Thanks
next prev parent reply other threads:[~2021-04-05 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 11:47 [PATCH for-next] RDMA/nldev: Add copy-on-fork attribute to get sys command Gal Pressman
2021-04-05 11:57 ` Leon Romanovsky
2021-04-05 11:58 ` Leon Romanovsky [this message]
2021-04-05 12:16 ` Gal Pressman
2021-04-05 12:15 ` Gal Pressman
2021-04-05 12:39 ` Leon Romanovsky
2021-04-05 13:09 ` Gal Pressman
2021-04-05 22:15 ` Jason Gunthorpe
2021-04-06 6:44 ` Leon Romanovsky
2021-04-06 14:31 ` Gal Pressman
2021-04-06 15:18 ` Jason Gunthorpe
2021-04-07 7:46 ` Gal Pressman
2021-04-06 14:50 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGr7bY9CcQoDXSb2@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).