Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang
@ 2021-03-05  8:48 Gustavo A. R. Silva
  2021-04-20 20:24 ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05  8:48 UTC (permalink / raw)
  To: Tariq Toukan, David S. Miller, Jakub Kicinski
  Cc: netdev, linux-rdma, linux-kernel, Gustavo A. R. Silva, linux-hardening

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
index a99e71bc7b3c..771b92019af1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
+++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
@@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,
 	case RES_XRCD:
 		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,
 				     vhcr->in_param, &vhcr->out_param);
+		break;
 
 	default:
 		break;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang
  2021-03-05  8:48 [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:24 ` Gustavo A. R. Silva
  2021-04-21  5:23   ` Leon Romanovsky
  0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:24 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Tariq Toukan, David S. Miller, Jakub Kicinski
  Cc: netdev, linux-rdma, linux-kernel, linux-hardening

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 02:48, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> index a99e71bc7b3c..771b92019af1 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> @@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,
>  	case RES_XRCD:
>  		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,
>  				     vhcr->in_param, &vhcr->out_param);
> +		break;
>  
>  	default:
>  		break;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang
  2021-04-20 20:24 ` Gustavo A. R. Silva
@ 2021-04-21  5:23   ` Leon Romanovsky
  0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-04-21  5:23 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Gustavo A. R. Silva, Tariq Toukan, David S. Miller,
	Jakub Kicinski, netdev, linux-rdma, linux-kernel,
	linux-hardening

On Tue, Apr 20, 2021 at 03:24:19PM -0500, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?

Why don't you fix Clang instead?
Why do we have this churn for something that correct?

> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 02:48, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of just letting the code
> > fall through to the next case.
> > 
> > Link: https://github.com/KSPP/linux/issues/115
> > Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> >  drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > index a99e71bc7b3c..771b92019af1 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
> > @@ -2660,6 +2660,7 @@ int mlx4_FREE_RES_wrapper(struct mlx4_dev *dev, int slave,
> >  	case RES_XRCD:
> >  		err = xrcdn_free_res(dev, slave, vhcr->op_modifier, alop,
> >  				     vhcr->in_param, &vhcr->out_param);
> > +		break;
> >  
> >  	default:
> >  		break;
> > 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  8:48 [PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:24 ` Gustavo A. R. Silva
2021-04-21  5:23   ` Leon Romanovsky

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git