From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321B9C433ED for ; Tue, 20 Apr 2021 09:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1E99611F2 for ; Tue, 20 Apr 2021 09:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230491AbhDTJJm (ORCPT ); Tue, 20 Apr 2021 05:09:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:53308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbhDTJJl (ORCPT ); Tue, 20 Apr 2021 05:09:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 765096101E; Tue, 20 Apr 2021 09:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618909750; bh=Zx+3BKAojnGAcSOH3f96YdKbuNqEzAUiJZBAF6GT+M8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gMrkhbWwZYNe4U/Hn7zbhwwvUlowNTN6ivMFRsUkVS3sExz7m0JS6bv7GtGyUPQXx E/8opgt2FVBBBXsFcrMWqZBYodYulxt3Ld/EC2OA3BhEw1Y8iFS6/o9GSKIw/u+t6y Sjo5yVfJUv3okjLSUUwp/9Dtf8guE2vs1o7dIAdvzGkrIjaFjHd6j/KwV+/BCWVz4T pNxKOiz5TwvcOgF/Oj8xTJTugJg8oFKms91OoMQIJC2xnSmjn3C5Gmp+LQcakDZ3im 9MXXv/QsYa22Nkq9lvpxp2359JU3uLuN23a07aRAy9v44rdAbSPFXRD0lLoMxipYTy naHrldgJlNBlg== Date: Tue, 20 Apr 2021 12:09:06 +0300 From: Leon Romanovsky To: "David S. Miller" , Jakub Kicinski Cc: Aditya Pakki , Santosh Shilimkar , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock Message-ID: References: <20210407000913.2207831-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210407000913.2207831-1-pakki001@umn.edu> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Apr 06, 2021 at 07:09:12PM -0500, Aditya Pakki wrote: > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avoid undefined behavior. >=20 > Signed-off-by: Aditya Pakki > --- > net/rds/message.c | 1 + > net/rds/send.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) Dave, Jakub Please revert this patch, given responses from Eric and Al together with this response from Greg here https://lore.kernel.org/lkml/YH5/i7OvsjSm= qADv@kroah.com BTW, I looked on the rds code too and agree with Eric, this patch is a total garbage. Thanks