From: Leon Romanovsky <leon@kernel.org>
To: shiraz.saleem@intel.com
Cc: zyjzyj2000@gmail.com, yanjun.zhu@intel.com,
mustafa.ismail@intel.com, dledford@redhat.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, yanjun.zhu@linux.dev,
Jakub Kicinski <kuba@kernel.org>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void
Date: Wed, 14 Jul 2021 12:14:58 +0300 [thread overview]
Message-ID: <YO6rEkoHgsYh+w37@unreal> (raw)
In-Reply-To: <20210714031130.1511109-2-yanjun.zhu@linux.dev>
On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The function irdma_sc_repost_aeq_entries always returns zero. So
> the returned type is changed to void.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 4 +---
> drivers/infiniband/hw/irdma/type.h | 3 +--
> 2 files changed, 2 insertions(+), 5 deletions(-)
<...>
> -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev,
> - u32 count);
I clearly remember that Jakub asked for more than once to remo remove
custom ice/irdma error codes. Did it happen? Can we get rid from them
in RDMA too?
Thanks
next prev parent reply other threads:[~2021-07-14 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 3:11 [PATCH 0/3] RDMA/irdma: do some cleanups yanjun.zhu
2021-07-14 3:11 ` [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void yanjun.zhu
2021-07-14 9:14 ` Leon Romanovsky [this message]
2021-07-14 9:23 ` Zhu Yanjun
2021-07-18 9:27 ` Leon Romanovsky
2021-07-14 3:11 ` [PATCH 2/3] RDMA/irdma: change the returned type of irdma_set_hw_rsrc " yanjun.zhu
2021-07-14 3:11 ` [PATCH 3/3] RDMA/irdma: change returned type of irdma_setup_virt_qp " yanjun.zhu
2021-07-15 18:19 ` [PATCH 0/3] RDMA/irdma: do some cleanups Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO6rEkoHgsYh+w37@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=yanjun.zhu@intel.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).