From: Leon Romanovsky <leon@kernel.org>
To: Wenpeng Liang <liangwenpeng@huawei.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Adit Ranadive <aditr@vmware.com>,
Ariel Elior <aelior@marvell.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Christian Benvenuti <benve@cisco.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Gal Pressman <galpress@amazon.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Steve Wise <larrystevenwise@gmail.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next 8/9] RDMA: Globally allocate and release QP memory
Date: Thu, 22 Jul 2021 11:16:29 +0300 [thread overview]
Message-ID: <YPkpXcPt7/I6PHZx@unreal> (raw)
In-Reply-To: <2d36585e-97da-1b27-4e2c-f3a7d2b76db7@huawei.com>
On Thu, Jul 22, 2021 at 03:59:04PM +0800, Wenpeng Liang wrote:
>
>
> On 2021/7/18 20:00, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > Convert QP object to follow IB/core general allocation scheme.
> > That change allows us to make sure that restrack properly kref
> > the memory.
> >
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> Hi, Leon, I tested your patchset, it looks good to hns.
> But there is a redundant assignment in hns.
> This is the patch.
Thanks a lot.
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
> index 364f404..fd0f71a 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_qp.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
> @@ -959,8 +959,6 @@ static int set_qp_param(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp,
> struct ib_device *ibdev = &hr_dev->ib_dev;
> int ret;
>
> - hr_qp->ibqp.qp_type = init_attr->qp_type;
> -
> if (init_attr->cap.max_inline_data > hr_dev->caps.max_sq_inline)
> init_attr->cap.max_inline_data = hr_dev->caps.max_sq_inline;
next prev parent reply other threads:[~2021-07-22 8:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 12:00 [PATCH rdma-next 0/9] QP allocation changes Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 1/9] RDMA/hns: Don't skip IB creation flow for regular RC QP Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 2/9] RDMA/hns: Don't overwrite supplied QP attributes Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 3/9] RDMA/efa: Remove double QP type assignment Leon Romanovsky
2021-07-19 13:40 ` Gal Pressman
2021-07-18 12:00 ` [PATCH rdma-next 4/9] RDMA/mlx5: Cancel pkey work before destroying device resources Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 5/9] RDMA/mlx5: Delete device resource mutex that didn't protect anything Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 6/9] RDMA/mlx5: Rework custom driver QP type creation Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 7/9] RDMA/rdmavt: Decouple QP and SGE lists allocations Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 8/9] RDMA: Globally allocate and release QP memory Leon Romanovsky
2021-07-19 13:42 ` Gal Pressman
2021-07-20 8:35 ` Leon Romanovsky
2021-07-21 18:05 ` Dennis Dalessandro
2021-07-22 7:05 ` Leon Romanovsky
2021-07-22 7:59 ` Wenpeng Liang
2021-07-22 8:16 ` Leon Romanovsky [this message]
2021-07-22 8:08 ` Wenpeng Liang
2021-07-18 12:00 ` [PATCH rdma-next 9/9] RDMA/mlx5: Drop in-driver verbs object creations Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPkpXcPt7/I6PHZx@unreal \
--to=leon@kernel.org \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@nvidia.com \
--cc=larrystevenwise@gmail.com \
--cc=liangwenpeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mkalderon@marvell.com \
--cc=mustafa.ismail@intel.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=pv-drivers@vmware.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).