From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Doug Ledford <dledford@redhat.com>,
Aharon Landau <aharonl@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Shay Drory <shayd@nvidia.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH mlx5-next 1/5] RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key
Date: Thu, 29 Jul 2021 20:27:07 +0300 [thread overview]
Message-ID: <YQLk65qM6oJ1J9fg@unreal> (raw)
In-Reply-To: <20210729152803.GA2394514@nvidia.com>
On Thu, Jul 29, 2021 at 12:28:03PM -0300, Jason Gunthorpe wrote:
> On Tue, Jun 22, 2021 at 03:08:19PM +0300, Leon Romanovsky wrote:
>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mr.c b/drivers/net/ethernet/mellanox/mlx5/core/mr.c
> > index 50af84e76fb6..7a76b5eb1c1a 100644
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/mr.c
> > @@ -35,13 +35,11 @@
> > #include <linux/mlx5/driver.h>
> > #include "mlx5_core.h"
> >
> > -int mlx5_core_create_mkey(struct mlx5_core_dev *dev,
> > - struct mlx5_core_mkey *mkey,
> > - u32 *in, int inlen)
> > +int mlx5_core_create_mkey(struct mlx5_core_dev *dev, u32 *mkey, u32 *in,
> > + int inlen)
> > {
> > u32 lout[MLX5_ST_SZ_DW(create_mkey_out)] = {};
> > u32 mkey_index;
> > - void *mkc;
> > int err;
> >
> > MLX5_SET(create_mkey_in, in, opcode, MLX5_CMD_OP_CREATE_MKEY);
> > @@ -50,38 +48,32 @@ int mlx5_core_create_mkey(struct mlx5_core_dev *dev,
> > if (err)
> > return err;
> >
> > - mkc = MLX5_ADDR_OF(create_mkey_in, in, memory_key_mkey_entry);
> > mkey_index = MLX5_GET(create_mkey_out, lout, mkey_index);
> > - mkey->iova = MLX5_GET64(mkc, mkc, start_addr);
> > - mkey->size = MLX5_GET64(mkc, mkc, len);
> > - mkey->key |= mlx5_idx_to_mkey(mkey_index);
> > - mkey->pd = MLX5_GET(mkc, mkc, pd);
> > - init_waitqueue_head(&mkey->wait);
> > + *mkey |= mlx5_idx_to_mkey(mkey_index);
>
>
> This conflicts with 0232fc2ddcf4 ("net/mlx5: Reset mkey index on creation")
>
> Please resend/rebase. I think it should be fixed like
>
> mkey_index = MLX5_GET(create_mkey_out, lout, mkey_index);
> *mkey = (u32)mlx5_mkey_variant(mkey->key) | mlx5_idx_to_mkey(mkey_index);
>
> mlx5_core_dbg(dev, "out 0x%x, mkey 0x%x\n", mkey_index, *mkey);
> ?
Yes, this is how it is fixed in my tree. I just waited till you finish the review.
>
> (though I will look at the rest of the series today, so don't rush on
> this)
>
> Jason
next prev parent reply other threads:[~2021-07-29 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 12:08 [PATCH rdma-next 0/5] mlx5 MR cache enhancements Leon Romanovsky
2021-06-22 12:08 ` [PATCH mlx5-next 1/5] RDMA/mlx5: Replace struct mlx5_core_mkey by u32 key Leon Romanovsky
2021-07-29 15:28 ` Jason Gunthorpe
2021-07-29 17:27 ` Leon Romanovsky [this message]
2021-07-29 18:08 ` Jason Gunthorpe
2021-06-22 12:08 ` [PATCH mlx5-next 2/5] RDMA/mlx5: Move struct mlx5_core_mkey to mlx5_ib Leon Romanovsky
2021-07-29 18:39 ` Jason Gunthorpe
2021-06-22 12:08 ` [PATCH mlx5-next 3/5] RDMA/mlx5: Change the cache to hold mkeys instead of MRs Leon Romanovsky
2021-07-29 19:08 ` Jason Gunthorpe
2021-06-22 12:08 ` [PATCH mlx5-next 4/5] RDMA/mlx5: Change the cache structure to an rbtree Leon Romanovsky
2021-07-29 19:45 ` Jason Gunthorpe
2021-06-22 12:08 ` [PATCH rdma-next 5/5] RDMA/mlx5: Delay the deregistration of a non-cache mkey Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQLk65qM6oJ1J9fg@unreal \
--to=leon@kernel.org \
--cc=aharonl@nvidia.com \
--cc=dledford@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).