From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1ACBC4338F for ; Mon, 2 Aug 2021 07:10:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9889460F5A for ; Mon, 2 Aug 2021 07:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232216AbhHBHK2 (ORCPT ); Mon, 2 Aug 2021 03:10:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:35486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbhHBHK2 (ORCPT ); Mon, 2 Aug 2021 03:10:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFABE60E97; Mon, 2 Aug 2021 07:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627888219; bh=neTkExLT95ampHqFETTwqaS+gbJQLI/MqzycCZyb9d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aJ4xm4JexiaXJwM+fk8ciDsJKMh3MclMGtQHOaS826FRSYzTfJDvx9HbSRKt4hZ9b 5dE9bZBbA6YU4Oq/tBe42dXbXmAu9lMRBgCBdXG3APmxNHuLnzNRugX15NLQ3Pl0GY MBhLPNaLwZUpPVbPCwUzgxdS4TPyFRV6BmLVW3LPzmxrzrammmMAWg061809VKrrur OW7mHRu9O5cJ+ZWF3G4P07ji4e5SusGCOdI7wT05tutjYB0+E5jK2Dd2E/EXECeLNy mHhXw6/7NEg/PdCw8MH9wsPmeOljMbEziDACuABhlTA+gnSV8l6QJ5JgSb6hI/n0N8 Zfx4hiMt+9IFg== Date: Mon, 2 Aug 2021 10:10:16 +0300 From: Leon Romanovsky To: Jack Wang Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, dledford@redhat.com, jgg@ziepe.ca, haris.iqbal@ionos.com, Gioh Kim Subject: Re: [PATCH for-next 07/10] RDMA/rtrs: Remove all likely and unlikely Message-ID: References: <20210730131832.118865-1-jinpu.wang@ionos.com> <20210730131832.118865-8-jinpu.wang@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210730131832.118865-8-jinpu.wang@ionos.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jul 30, 2021 at 03:18:29PM +0200, Jack Wang wrote: > From: Gioh Kim > > The IO performance test with fio after swapping the likely > and unlikely macros in all if-statement shows no difference. > They do not help for the performance of rtrs. > > Thanks to Haakon Bugge for the test scenario. > > The fio test did random read on 32 rnbd devices and 64 processes. > Test environment: > - Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz > - 376G memory > - kernel version: 5.4.86 > - gcc version: gcc (Debian 8.3.0-6) 8.3.0 > - Infiniband controller: Mellanox Technologies MT27800 Family > [ConnectX-5] > > Test result: > - before swapping: IOPS=829k, BW=3239MiB/s > - after swapping: IOPS=829k, BW=3238MiB/s > - remove all (un)likely: IOPS=829k, BW=3238MiB/s > > Signed-off-by: Gioh Kim > Signed-off-by: Jack Wang > --- > drivers/infiniband/ulp/rtrs/rtrs-clt-stats.c | 2 +- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 126 +++++++++---------- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 74 ++++++----- > 3 files changed, 99 insertions(+), 103 deletions(-) > Thanks a lot, Reviewed-by: Leon Romanovsky