From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8FB3C4332F for ; Tue, 21 Sep 2021 07:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D085A610CA for ; Tue, 21 Sep 2021 07:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbhIUHDz (ORCPT ); Tue, 21 Sep 2021 03:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbhIUHDy (ORCPT ); Tue, 21 Sep 2021 03:03:54 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A825C061756 for ; Tue, 21 Sep 2021 00:02:26 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id t8so36153972wrq.4 for ; Tue, 21 Sep 2021 00:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fusWwRhGhDwMDvQIF2rL+xIXyvzxwvV+7P1DjBX2OMs=; b=17ypAGfGNToM0JSjgeiOeGU851YZP0qvqVdPT5/wmSGdUXJ3vAdN4BAOh9A7cDHB5a AnweVmVoZRkGEn+GBVrYIQJd5My/8znNb84Dvybfp4W0w9vScptNps5QF4U38ECx8tco 2CUiLk/agsteCVIQEkd6qe8/ZujmvYC530UJdreb3wyzUMUX856xFPlfx76NWSoFwnG1 TJ/Ec8u3HAEpAo2vhZp3kkGaHNZllUxLafsuh5no2ljfi6wB0kQS2njBg3M1W6AX7AaO aSE5wCot9OdHYI6j7SWUcVGhTfLuNKk3qPN4/rl2YtlAcak1FryT5nuJWc9hr7UMCrut ETNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fusWwRhGhDwMDvQIF2rL+xIXyvzxwvV+7P1DjBX2OMs=; b=pYYSw+2MN1WZiTTaNPH/+X8bmNCDB2kQ8+KPGUiLpfIBpHKO/8M1aROdUWTfGhMu/G fCQTg8fb99jy0Z0jkr55XERZJC1Pz3n49Ioxp21t02Zq4ym10uHJjbvJMjJKU3hmdAM9 arx8TVWKjzNb/olBW4QO2s4KRL2HE3O7JdF2GLw8sMwXOH+Q8FeQzr7KuCqSnYZHHDIm s/WsgiOQJL1bGI16L6vIxIrBbtwsd1LaubSTE/4spRyNSOeYQgO9lVo0HHL9cWa/O7eh PYg9ZDxTxCkJ/P8Pwn19wZRBgCXAD9eEfvcJxCXvp1nixIxuQG1sTNo6hKSbMUlQrsQl C7nw== X-Gm-Message-State: AOAM531/40V80MQICTriHRUpBKyLVihHXC2YS2DnOtF005vJfGOdZcnP w7vunxynngYoX7yno+mxTk9Okg== X-Google-Smtp-Source: ABdhPJz0OlMS4q0UvEdCzO4nXU7/PwGZ8ozvQmNUB80OlTlbJwb+ceMDZjLzoyimOSm5UKvaW2UlrA== X-Received: by 2002:a5d:6c6d:: with SMTP id r13mr17856595wrz.439.1632207745235; Tue, 21 Sep 2021 00:02:25 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id r25sm19674308wrc.26.2021.09.21.00.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 00:02:24 -0700 (PDT) Date: Tue, 21 Sep 2021 09:02:23 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Leon Romanovsky , "David S . Miller" , Leon Romanovsky , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , drivers@pensando.io, Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, hariprasad , Ido Schimmel , intel-wired-lan@lists.osuosl.org, Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev, Manish Chopra , Michael Chan , netdev@vger.kernel.org, oss-drivers@corigine.com, Richard Cochran , Saeed Mahameed , Salil Mehta , Satanand Burla , Shannon Nelson , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , UNGLinuxDriver@microchip.com, Vadym Kochan , Vivien Didelot , Vladimir Oltean , Yisen Zhuang Subject: Re: [PATCH net-next] devlink: Make devlink_register to be void Message-ID: References: <2e089a45e03db31bf451d768fc588c02a2f781e8.1632148852.git.leonro@nvidia.com> <20210920133915.59ddfeef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920133915.59ddfeef@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Mon, Sep 20, 2021 at 10:39:15PM CEST, kuba@kernel.org wrote: >On Mon, 20 Sep 2021 17:41:44 +0300 Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> devlink_register() can't fail and always returns success, but all drivers >> are obligated to check returned status anyway. This adds a lot of boilerplate >> code to handle impossible flow. >> >> Make devlink_register() void and simplify the drivers that use that >> API call. > >Unlike unused functions bringing back error handling may be >non-trivial. I'd rather you deferred such cleanups until you're >ready to post your full rework and therefore give us some confidence >the revert will not be needed. Well, that was the original reason why I made it to return int, so the drivers are prepared. But truth is that given the time this is on and the need to return int never really materialized, I tend to ack with the cleanup.