From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A83C433EF for ; Wed, 29 Sep 2021 14:20:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41DEA613CD for ; Wed, 29 Sep 2021 14:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343989AbhI2OVq (ORCPT ); Wed, 29 Sep 2021 10:21:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:52674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244206AbhI2OVp (ORCPT ); Wed, 29 Sep 2021 10:21:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8794A613A7; Wed, 29 Sep 2021 14:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632925204; bh=/rFaJ/GWthiiFP4i+etBeG9LoeoqNtBGaxI8dkwdWLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dLQUd2R30FU25Q/pjWqD86gU0LXsOCAmuWbfatlF3n9gTH/eVaBbejlM0Y/nVbnww 8jJK3Ke33wZm6ugH6Iwao5v/m8+mvqJq+4a7nfRpiRrv+xzQcP/yJ4PDuwunfqH/Ob 1RnQUotHpv3iGcDBBaH7bDCo9PvtoHSrHZnzp5nZlP4jWZNcBRh4TmjOW9XEgPOpSD YP8Iq1E1hWL3yKuRMZoba9u7eh6W6tEUcP1pl6UEhCfZkZRWyOXComIOAdaKdiPagT ST6EvIYLEbPG4Px00nnpK6oecE1OnqFOF1L4ql37gIAiW5GyKg9MULEYCT5Z8EGHa8 eLZbXug7Mf1tA== Date: Wed, 29 Sep 2021 17:20:01 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: Vladimir Oltean , "David S . Miller" , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , "drivers@pensando.io" , Eric Dumazet , Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , "GR-everest-linux-l2@marvell.com" , "GR-Linux-NIC-Dev@marvell.com" , hariprasad , Ido Schimmel , "intel-wired-lan@lists.osuosl.org" , Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-staging@lists.linux.dev" , Manish Chopra , Michael Chan , Moshe Shemesh , "netdev@vger.kernel.org" , "oss-drivers@corigine.com" , Richard Cochran , Saeed Mahameed , Salil Mehta , Satanand Burla , Shannon Nelson , Shay Drory , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , "UNGLinuxDriver@microchip.com" , Vadym Kochan , Vivien Didelot , Yisen Zhuang Subject: Re: [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Message-ID: References: <20210929064004.3172946e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929134637.4wlbd5ehbgc55cuo@skbuf> <20210929065621.20cb08ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929065621.20cb08ad@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Sep 29, 2021 at 06:56:21AM -0700, Jakub Kicinski wrote: > On Wed, 29 Sep 2021 13:46:38 +0000 Vladimir Oltean wrote: > > On Wed, Sep 29, 2021 at 06:40:04AM -0700, Jakub Kicinski wrote: > > > Swapping ops is a nasty hack in my book. > > > > > > And all that to avoid having two op structures in one driver. > > > Or to avoid having counters which are always 0? > > > > > > Sorry, at the very least you need better explanation for this. > > > > Leon, while the discussion about this unfolds, can you please repost > > patch 1 separately? :) > > Yes, please and thanks! :) Done, thanks https://lore.kernel.org/netdev/2ed1159291f2a589b013914f2b60d8172fc525c1.1632925030.git.leonro@nvidia.com/T/#u