From: Leon Romanovsky <leon@kernel.org>
To: Wenpeng Liang <liangwenpeng@huawei.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v2 for-next 5/9] RDMA/hns: Refactor mailbox functions
Date: Mon, 28 Feb 2022 14:03:28 +0200 [thread overview]
Message-ID: <Yhy6ENF7epAa/FGs@unreal> (raw)
In-Reply-To: <20220225112559.43300-6-liangwenpeng@huawei.com>
On Fri, Feb 25, 2022 at 07:25:55PM +0800, Wenpeng Liang wrote:
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> The current mailbox functions have too many parameters, making the code
> difficult to maintain. So construct a new structure mbox_msg to pass the
> information needed by mailbox.
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_cmd.c | 73 ++++++------
> drivers/infiniband/hw/hns/hns_roce_cmd.h | 2 +-
> drivers/infiniband/hw/hns/hns_roce_cq.c | 9 +-
> drivers/infiniband/hw/hns/hns_roce_device.h | 14 ++-
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 111 +++++++++---------
> .../infiniband/hw/hns/hns_roce_hw_v2_dfx.c | 4 +-
> drivers/infiniband/hw/hns/hns_roce_mr.c | 13 +-
> drivers/infiniband/hw/hns/hns_roce_srq.c | 6 +-
> 8 files changed, 120 insertions(+), 112 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-02-28 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 11:25 [PATCH v2 for-next 0/9] RDMA/hns: Clean up and refactor mailbox-related code Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 1/9] RDMA/hns: Remove the unused parameter "op_modifier" in mailbox Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 2/9] RDMA/hns: Remove fixed parameter “timeout” in the mailbox Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 3/9] RDMA/hns: Remove redundant parameter "mailbox" " Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 4/9] RDMA/hns: Fix the wrong type of parameter "op" of " Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 5/9] RDMA/hns: Refactor mailbox functions Wenpeng Liang
2022-02-28 12:03 ` Leon Romanovsky [this message]
2022-02-25 11:25 ` [PATCH v2 for-next 6/9] RDMA/hns: Remove similar code that configures the hardware contexts Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 7/9] RDMA/hns: Clean up the return value check of hns_roce_alloc_cmd_mailbox() Wenpeng Liang
2022-02-28 12:03 ` Leon Romanovsky
2022-02-28 16:04 ` Jason Gunthorpe
2022-03-02 2:28 ` Wenpeng Liang
2022-02-25 11:25 ` [PATCH v2 for-next 8/9] RDMA/hns: Refactor the alloc_srqc() Wenpeng Liang
2022-02-28 12:04 ` Leon Romanovsky
2022-02-25 11:25 ` [PATCH v2 for-next 9/9] RDMA/hns: Refactor the alloc_cqc() Wenpeng Liang
2022-02-28 12:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhy6ENF7epAa/FGs@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=liangwenpeng@huawei.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).