* [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
@ 2020-06-02 12:28 Leon Romanovsky
2020-06-02 19:27 ` Nathan Chancellor
2020-06-02 22:33 ` David Miller
0 siblings, 2 replies; 7+ messages in thread
From: Leon Romanovsky @ 2020-06-02 12:28 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski
Cc: Leon Romanovsky, clang-built-linux, linux-rdma,
Nathan Chancellor, netdev, Saeed Mahameed, Vu Pham
From: Leon Romanovsky <leonro@mellanox.com>
Clang warns:
drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable
'err' is used uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (!priv->dbg_root) {
^~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
uninitialized use occurs here
return err;
^~~
drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note: remove the
'if' if its condition is always false
if (!priv->dbg_root) {
^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note: initialize
the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.
The check of returned value of debugfs_create_dir() is wrong because
by the design debugfs failures should never fail the driver and the
check itself was wrong too. The kernel compiled without CONFIG_DEBUG_FS
will return ERR_PTR(-ENODEV) and not NULL as expected.
Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci init")
Link: https://github.com/ClangBuiltLinux/linux/issues/1042
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
Original discussion:
https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index df46b1fce3a7..110e8d277d15 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct mlx5_core_dev *dev, int profile_idx)
priv->dbg_root = debugfs_create_dir(dev_name(dev->device),
mlx5_debugfs_root);
- if (!priv->dbg_root) {
- dev_err(dev->device, "mlx5_core: error, Cannot create debugfs dir, aborting\n");
- goto err_dbg_root;
- }
-
err = mlx5_health_init(dev);
if (err)
goto err_health_init;
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-02 12:28 [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs Leon Romanovsky
@ 2020-06-02 19:27 ` Nathan Chancellor
2020-06-03 18:34 ` Nathan Chancellor
2020-06-02 22:33 ` David Miller
1 sibling, 1 reply; 7+ messages in thread
From: Nathan Chancellor @ 2020-06-02 19:27 UTC (permalink / raw)
To: Leon Romanovsky
Cc: David S . Miller, Jakub Kicinski, Leon Romanovsky,
clang-built-linux, linux-rdma, netdev, Saeed Mahameed, Vu Pham
On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> Clang warns:
>
> drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable
> 'err' is used uninitialized whenever 'if' condition is true
> [-Wsometimes-uninitialized]
> if (!priv->dbg_root) {
> ^~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
> uninitialized use occurs here
> return err;
> ^~~
> drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note: remove the
> 'if' if its condition is always false
> if (!priv->dbg_root) {
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note: initialize
> the variable 'err' to silence this warning
> int err;
> ^
> = 0
> 1 warning generated.
>
> The check of returned value of debugfs_create_dir() is wrong because
> by the design debugfs failures should never fail the driver and the
> check itself was wrong too. The kernel compiled without CONFIG_DEBUG_FS
> will return ERR_PTR(-ENODEV) and not NULL as expected.
>
> Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci init")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1042
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Thanks! That's what I figured it should be.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> Original discussion:
> https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
> ---
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index df46b1fce3a7..110e8d277d15 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct mlx5_core_dev *dev, int profile_idx)
>
> priv->dbg_root = debugfs_create_dir(dev_name(dev->device),
> mlx5_debugfs_root);
> - if (!priv->dbg_root) {
> - dev_err(dev->device, "mlx5_core: error, Cannot create debugfs dir, aborting\n");
> - goto err_dbg_root;
> - }
> -
> err = mlx5_health_init(dev);
> if (err)
> goto err_health_init;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-02 12:28 [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs Leon Romanovsky
2020-06-02 19:27 ` Nathan Chancellor
@ 2020-06-02 22:33 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2020-06-02 22:33 UTC (permalink / raw)
To: leon
Cc: kuba, leonro, clang-built-linux, linux-rdma, natechancellor,
netdev, saeedm, vuhuong
Saeed, please pick this up.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-02 19:27 ` Nathan Chancellor
@ 2020-06-03 18:34 ` Nathan Chancellor
2020-06-04 4:44 ` Saeed Mahameed
0 siblings, 1 reply; 7+ messages in thread
From: Nathan Chancellor @ 2020-06-03 18:34 UTC (permalink / raw)
To: Leon Romanovsky
Cc: David S . Miller, Jakub Kicinski, Leon Romanovsky,
clang-built-linux, linux-rdma, netdev, Saeed Mahameed, Vu Pham
On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote:
> On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Clang warns:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable
> > 'err' is used uninitialized whenever 'if' condition is true
> > [-Wsometimes-uninitialized]
> > if (!priv->dbg_root) {
> > ^~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
> > uninitialized use occurs here
> > return err;
> > ^~~
> > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note: remove the
> > 'if' if its condition is always false
> > if (!priv->dbg_root) {
> > ^~~~~~~~~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note: initialize
> > the variable 'err' to silence this warning
> > int err;
> > ^
> > = 0
> > 1 warning generated.
> >
> > The check of returned value of debugfs_create_dir() is wrong because
> > by the design debugfs failures should never fail the driver and the
> > check itself was wrong too. The kernel compiled without CONFIG_DEBUG_FS
> > will return ERR_PTR(-ENODEV) and not NULL as expected.
> >
> > Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci init")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1042
> > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>
> Thanks! That's what I figured it should be.
>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
>
> > ---
> > Original discussion:
> > https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > index df46b1fce3a7..110e8d277d15 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > @@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct mlx5_core_dev *dev, int profile_idx)
> >
> > priv->dbg_root = debugfs_create_dir(dev_name(dev->device),
> > mlx5_debugfs_root);
> > - if (!priv->dbg_root) {
> > - dev_err(dev->device, "mlx5_core: error, Cannot create debugfs dir, aborting\n");
> > - goto err_dbg_root;
Actually, this removes the only use of err_dbg_root, so that should be
removed at the same time.
Cheers,
Nathan
> > - }
> > -
> > err = mlx5_health_init(dev);
> > if (err)
> > goto err_health_init;
> > --
> > 2.26.2
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-03 18:34 ` Nathan Chancellor
@ 2020-06-04 4:44 ` Saeed Mahameed
2020-06-08 21:22 ` Nathan Chancellor
0 siblings, 1 reply; 7+ messages in thread
From: Saeed Mahameed @ 2020-06-04 4:44 UTC (permalink / raw)
To: natechancellor, leon
Cc: linux-rdma, clang-built-linux, Vu Pham, davem, kuba,
Leon Romanovsky, netdev
On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote:
> On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote:
> > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Clang warns:
> > >
> > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning:
> > > variable
> > > 'err' is used uninitialized whenever 'if' condition is true
> > > [-Wsometimes-uninitialized]
> > > if (!priv->dbg_root) {
> > > ^~~~~~~~~~~~~~~
> > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
> > > uninitialized use occurs here
> > > return err;
> > > ^~~
> > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note:
> > > remove the
> > > 'if' if its condition is always false
> > > if (!priv->dbg_root) {
> > > ^~~~~~~~~~~~~~~~~~~~~~
> > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note:
> > > initialize
> > > the variable 'err' to silence this warning
> > > int err;
> > > ^
> > > = 0
> > > 1 warning generated.
> > >
> > > The check of returned value of debugfs_create_dir() is wrong
> > > because
> > > by the design debugfs failures should never fail the driver and
> > > the
> > > check itself was wrong too. The kernel compiled without
> > > CONFIG_DEBUG_FS
> > > will return ERR_PTR(-ENODEV) and not NULL as expected.
> > >
> > > Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci init")
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1042
> > > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> >
> > Thanks! That's what I figured it should be.
> >
> > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> >
> > > ---
> > > Original discussion:
> > > https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
> > > ---
> > > drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > index df46b1fce3a7..110e8d277d15 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > @@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct
> > > mlx5_core_dev *dev, int profile_idx)
> > >
> > > priv->dbg_root = debugfs_create_dir(dev_name(dev->device),
> > > mlx5_debugfs_root);
> > > - if (!priv->dbg_root) {
> > > - dev_err(dev->device, "mlx5_core: error, Cannot create
> > > debugfs dir, aborting\n");
> > > - goto err_dbg_root;
>
> Actually, this removes the only use of err_dbg_root, so that should
> be
> removed at the same time.
>
Fixed this up and applied to net-next-mlx5,
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-04 4:44 ` Saeed Mahameed
@ 2020-06-08 21:22 ` Nathan Chancellor
2020-06-11 21:58 ` Saeed Mahameed
0 siblings, 1 reply; 7+ messages in thread
From: Nathan Chancellor @ 2020-06-08 21:22 UTC (permalink / raw)
To: Saeed Mahameed
Cc: leon, linux-rdma, clang-built-linux, Vu Pham, davem, kuba,
Leon Romanovsky, netdev
On Thu, Jun 04, 2020 at 04:44:00AM +0000, Saeed Mahameed wrote:
> On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote:
> > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor wrote:
> > > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@mellanox.com>
> > > >
> > > > Clang warns:
> > > >
> > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning:
> > > > variable
> > > > 'err' is used uninitialized whenever 'if' condition is true
> > > > [-Wsometimes-uninitialized]
> > > > if (!priv->dbg_root) {
> > > > ^~~~~~~~~~~~~~~
> > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
> > > > uninitialized use occurs here
> > > > return err;
> > > > ^~~
> > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note:
> > > > remove the
> > > > 'if' if its condition is always false
> > > > if (!priv->dbg_root) {
> > > > ^~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note:
> > > > initialize
> > > > the variable 'err' to silence this warning
> > > > int err;
> > > > ^
> > > > = 0
> > > > 1 warning generated.
> > > >
> > > > The check of returned value of debugfs_create_dir() is wrong
> > > > because
> > > > by the design debugfs failures should never fail the driver and
> > > > the
> > > > check itself was wrong too. The kernel compiled without
> > > > CONFIG_DEBUG_FS
> > > > will return ERR_PTR(-ENODEV) and not NULL as expected.
> > > >
> > > > Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci init")
> > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1042
> > > > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Thanks! That's what I figured it should be.
> > >
> > > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> > >
> > > > ---
> > > > Original discussion:
> > > > https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
> > > > ---
> > > > drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
> > > > 1 file changed, 5 deletions(-)
> > > >
> > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > index df46b1fce3a7..110e8d277d15 100644
> > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > @@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct
> > > > mlx5_core_dev *dev, int profile_idx)
> > > >
> > > > priv->dbg_root = debugfs_create_dir(dev_name(dev->device),
> > > > mlx5_debugfs_root);
> > > > - if (!priv->dbg_root) {
> > > > - dev_err(dev->device, "mlx5_core: error, Cannot create
> > > > debugfs dir, aborting\n");
> > > > - goto err_dbg_root;
> >
> > Actually, this removes the only use of err_dbg_root, so that should
> > be
> > removed at the same time.
> >
>
> Fixed this up and applied to net-next-mlx5,
> Thanks!
>
Hi Saeed,
I see this warning in mainline now, is this something you were planning
to have merged this cycle or next? I see it in several configs so it
would be nice if it could be resolved this one, since it was introduced
by a patch in this cycle even though the core issue has been around for
a few months.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs
2020-06-08 21:22 ` Nathan Chancellor
@ 2020-06-11 21:58 ` Saeed Mahameed
0 siblings, 0 replies; 7+ messages in thread
From: Saeed Mahameed @ 2020-06-11 21:58 UTC (permalink / raw)
To: natechancellor
Cc: linux-rdma, Leon Romanovsky, Vu Pham, davem, clang-built-linux,
kuba, netdev, leon
On Mon, 2020-06-08 at 14:22 -0700, Nathan Chancellor wrote:
> On Thu, Jun 04, 2020 at 04:44:00AM +0000, Saeed Mahameed wrote:
> > On Wed, 2020-06-03 at 11:34 -0700, Nathan Chancellor wrote:
> > > On Tue, Jun 02, 2020 at 12:27:24PM -0700, Nathan Chancellor
> > > wrote:
> > > > On Tue, Jun 02, 2020 at 03:28:37PM +0300, Leon Romanovsky
> > > > wrote:
> > > > > From: Leon Romanovsky <leonro@mellanox.com>
> > > > >
> > > > > Clang warns:
> > > > >
> > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6:
> > > > > warning:
> > > > > variable
> > > > > 'err' is used uninitialized whenever 'if' condition is true
> > > > > [-Wsometimes-uninitialized]
> > > > > if (!priv->dbg_root) {
> > > > > ^~~~~~~~~~~~~~~
> > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1303:9: note:
> > > > > uninitialized use occurs here
> > > > > return err;
> > > > > ^~~
> > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:2: note:
> > > > > remove the
> > > > > 'if' if its condition is always false
> > > > > if (!priv->dbg_root) {
> > > > > ^~~~~~~~~~~~~~~~~~~~~~
> > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1259:9: note:
> > > > > initialize
> > > > > the variable 'err' to silence this warning
> > > > > int err;
> > > > > ^
> > > > > = 0
> > > > > 1 warning generated.
> > > > >
> > > > > The check of returned value of debugfs_create_dir() is wrong
> > > > > because
> > > > > by the design debugfs failures should never fail the driver
> > > > > and
> > > > > the
> > > > > check itself was wrong too. The kernel compiled without
> > > > > CONFIG_DEBUG_FS
> > > > > will return ERR_PTR(-ENODEV) and not NULL as expected.
> > > > >
> > > > > Fixes: 11f3b84d7068 ("net/mlx5: Split mdev init and pci
> > > > > init")
> > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1042
> > > > > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> > > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > > >
> > > > Thanks! That's what I figured it should be.
> > > >
> > > > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> > > >
> > > > > ---
> > > > > Original discussion:
> > > > > https://lore.kernel.org/lkml/20200530055447.1028004-1-natechancellor@gmail.com
> > > > > ---
> > > > > drivers/net/ethernet/mellanox/mlx5/core/main.c | 5 -----
> > > > > 1 file changed, 5 deletions(-)
> > > > >
> > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > > b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > > index df46b1fce3a7..110e8d277d15 100644
> > > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > > > > @@ -1275,11 +1275,6 @@ static int mlx5_mdev_init(struct
> > > > > mlx5_core_dev *dev, int profile_idx)
> > > > >
> > > > > priv->dbg_root = debugfs_create_dir(dev_name(dev-
> > > > > >device),
> > > > > mlx5_debugfs_root);
> > > > > - if (!priv->dbg_root) {
> > > > > - dev_err(dev->device, "mlx5_core: error, Cannot
> > > > > create
> > > > > debugfs dir, aborting\n");
> > > > > - goto err_dbg_root;
> > >
> > > Actually, this removes the only use of err_dbg_root, so that
> > > should
> > > be
> > > removed at the same time.
> > >
> >
> > Fixed this up and applied to net-next-mlx5,
> > Thanks!
> >
>
> Hi Saeed,
>
> I see this warning in mainline now, is this something you were
> planning
> to have merged this cycle or next? I see it in several configs so it
> would be nice if it could be resolved this one, since it was
> introduced
> by a patch in this cycle even though the core issue has been around
> for
> a few months.
>
Hi Nathan,
I just pulled this patch into net-mlx5, and will send it out in my net
PR today.
Thanks,
Saeed.
> Cheers,
> Nathan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-06-11 21:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 12:28 [PATCH net] net/mlx5: Don't fail driver on failure to create debugfs Leon Romanovsky
2020-06-02 19:27 ` Nathan Chancellor
2020-06-03 18:34 ` Nathan Chancellor
2020-06-04 4:44 ` Saeed Mahameed
2020-06-08 21:22 ` Nathan Chancellor
2020-06-11 21:58 ` Saeed Mahameed
2020-06-02 22:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).