linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, tariqt@nvidia.com, yishaih@nvidia.com,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] mlx4: replace mlx4_mac_to_u64() with ether_addr_to_u64()
Date: Tue, 5 Oct 2021 12:55:42 +0300	[thread overview]
Message-ID: <a428a7fd-1c2b-ab8e-b032-f7b8d4b293d9@gmail.com> (raw)
In-Reply-To: <20211004191446.2127522-2-kuba@kernel.org>



On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
> mlx4_mac_to_u64() predates and opencodes ether_addr_to_u64().
> It doesn't make the argument constant so it'll be problematic
> when dev->dev_addr becomes a const. Convert to the generic helper.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>   drivers/infiniband/hw/mlx4/main.c              |  2 +-
>   drivers/infiniband/hw/mlx4/qp.c                |  2 +-
>   drivers/net/ethernet/mellanox/mlx4/cmd.c       |  2 +-
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 16 ++++++++--------
>   drivers/net/ethernet/mellanox/mlx4/fw.c        |  2 +-
>   include/linux/mlx4/driver.h                    | 12 ------------
>   6 files changed, 12 insertions(+), 24 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>


  reply	other threads:[~2021-10-05  9:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 19:14 [PATCH net-next 0/4] mlx4: prep for constant dev->dev_addr Jakub Kicinski
2021-10-04 19:14 ` [PATCH net-next 1/4] mlx4: replace mlx4_mac_to_u64() with ether_addr_to_u64() Jakub Kicinski
2021-10-05  9:55   ` Tariq Toukan [this message]
2021-10-04 19:14 ` [PATCH net-next 2/4] mlx4: replace mlx4_u64_to_mac() with u64_to_ether_addr() Jakub Kicinski
2021-10-05  9:59   ` Tariq Toukan
2021-10-04 19:14 ` [PATCH net-next 3/4] mlx4: remove custom dev_addr clearing Jakub Kicinski
2021-10-05 10:21   ` Tariq Toukan
2021-10-04 19:14 ` [PATCH net-next 4/4] mlx4: constify args for const dev_addr Jakub Kicinski
2021-10-05 10:27   ` Tariq Toukan
2021-10-05 10:28 ` [PATCH net-next 0/4] mlx4: prep for constant dev->dev_addr Tariq Toukan
2021-10-05 12:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a428a7fd-1c2b-ab8e-b032-f7b8d4b293d9@gmail.com \
    --to=ttoukan.linux@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@nvidia.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).