linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@gentwo.de>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kamal Heib <kamalheib1@gmail.com>,
	Alaa Hleihel <alaa@mellanox.com>,
	Valentine Fatiev <valentinef@mellanox.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	kael_w@yeah.net
Subject: Re: [PATCH] infiniband: ulp: Remove unnecessary struct declaration
Date: Thu, 15 Apr 2021 11:47:34 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2104151147070.633142@gentwo.de> (raw)
In-Reply-To: <20210415092124.27684-1-wanjiabing@vivo.com>

On Thu, 15 Apr 2021, Wan Jiabing wrote:

> struct ipoib_cm_tx is defined at 245th line.
> And the definition is independent on the MACRO.
> The declaration here is unnecessary. Remove it.

Correct.

Reviewed-by: Christoph Lameter <cl@linux.com>


  reply	other threads:[~2021-04-15  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  9:21 [PATCH] infiniband: ulp: Remove unnecessary struct declaration Wan Jiabing
2021-04-15  9:47 ` Christoph Lameter [this message]
2021-04-20 19:09 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2104151147070.633142@gentwo.de \
    --to=cl@gentwo.de \
    --cc=alaa@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kael_w@yeah.net \
    --cc=kamalheib1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=valentinef@mellanox.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).