Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: Max Gurtovoy <maxg@mellanox.com>
To: Jason Gunthorpe <jgg@mellanox.com>,
	Sergey Gorenko <sergeygo@mellanox.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH v1] IB/iser: Support up to 16MB data transfer in a single command
Date: Fri, 13 Sep 2019 00:14:14 +0300
Message-ID: <b49453d9-d419-f804-35a9-757a9b8206b9@mellanox.com> (raw)
In-Reply-To: <20190912151931.GA15637@mellanox.com>


On 9/12/2019 6:19 PM, Jason Gunthorpe wrote:
> On Thu, Sep 12, 2019 at 10:35:34AM +0000, Sergey Gorenko wrote:
>> Maximum supported IO size is 8MB for the iSER driver. The
>> current value is limited by the ISCSI_ISER_MAX_SG_TABLESIZE
>> macro. But the driver is able to handle 16MB IOs without any
>> significant changes. Increasing this limit can be useful for
>> the storage arrays which are fine tuned for IOs larger than
>> 8 MB.
>>
>> This commit allows to configure maximum IO size up to 16MB
>> using the max_sectors module parameter.
>>
>> Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>
>> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
>> Acked-by: Sagi Grimberg <sagi@grimberg.me>
>> ---
>> Changes from v0:
>> - Change 512 to SECTOR_SIZE (suggested by Sagi)

is this always true ? 512 == SECTOR_SIZE ?


>>
>>   drivers/infiniband/ulp/iser/iscsi_iser.h | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
> Applied to for-next with Sagi's ack
>
> Thanks,
> Jason

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 10:35 Sergey Gorenko
2019-09-12 15:19 ` Jason Gunthorpe
2019-09-12 21:14   ` Max Gurtovoy [this message]
2019-09-12 21:45     ` Sagi Grimberg

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b49453d9-d419-f804-35a9-757a9b8206b9@mellanox.com \
    --to=maxg@mellanox.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=sergeygo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org linux-rdma@archiver.kernel.org
	public-inbox-index linux-rdma


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/ public-inbox