From: Pierre-Louis Bossart <firstname.lastname@example.org> To: Jason Gunthorpe <email@example.com> Cc: Ranjani Sridharan <firstname.lastname@example.org>, Jeff Kirsher <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Fred Oh <firstname.lastname@example.org> Subject: Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client Date: Fri, 22 May 2020 13:48:00 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20200522184035.GL17583@ziepe.ca> On 5/22/20 1:40 PM, Jason Gunthorpe wrote: > On Fri, May 22, 2020 at 01:35:54PM -0500, Pierre-Louis Bossart wrote: >> >> >> On 5/22/20 12:10 PM, Jason Gunthorpe wrote: >>> On Fri, May 22, 2020 at 10:33:20AM -0500, Pierre-Louis Bossart wrote: >>> >>>>> Maybe not great, but at least it is consistent with all the lifetime >>>>> models and the operation of the driver core. >>>> >>>> I agree your comments are valid ones, I just don't have a solution to be >>>> fully compliant with these models and report failures of the driver probe >>>> for a child device due to configuration issues (bad audio topology, etc). >>> >>> >>>> My understanding is that errors on probe are explicitly not handled in the >>>> driver core, see e.g. comments such as: >>> >>> Yes, but that doesn't really apply here... >>>> /* >>>> * Ignore errors returned by ->probe so that the next driver can try >>>> * its luck. >>>> */ >>>> https://elixir.bootlin.com/linux/latest/source/drivers/base/dd.c#L636 >>>> >>>> If somehow we could request the error to be reported then probably we >>>> wouldn't need this complete/wait_for_completion mechanism as a custom >>>> notification. >>> >>> That is the same issue as the completion, a driver should not be >>> making assumptions about ordering like this. For instance what if the >>> current driver is in the initrd and the 2nd driver is in a module in >>> the filesystem? It will not probe until the system boots more >>> completely. >>> >>> This is all stuff that is supposed to work properly. >>> >>>> Not at the moment, no. there are no failures reported in dmesg, and >>>> the user does not see any card created. This is a silent error. >>> >>> Creating a partial non-function card until all the parts are loaded >>> seems like the right way to surface an error like this. >>> >>> Or don't break the driver up in this manner if all the parts are really >>> required just for it to function - quite strange place to get into. >> >> This is not about having all the parts available - that's handled already >> with deferred probe - but an error happening during card registration. In >> that case the ALSA/ASoC core throws an error and we cannot report it back to >> the parent. > > The whole point of the virtual bus stuff was to split up a > multi-functional PCI device into parts. If all the parts are required > to be working to make the device work, why are you using virtual bus > here? It's the other way around: how does the core know that one part isn't functional. There is nothing in what we said that requires that all parts are fully functional. All we stated is that when *one* part isn't fully functional we know about it. >>> What happens if the user unplugs this sub driver once things start >>> running? >> >> refcounting in the ALSA core prevents that from happening usually. > > So user triggered unplug of driver that attaches here just hangs > forever? That isn't OK either. No, you'd get a 'module in use' error if I am not mistaken.
next prev parent reply other threads:[~2020-05-22 18:48 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-20 7:02 [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 01/12] Implementation of Virtual Bus Jeff Kirsher 2020-05-21 14:57 ` Parav Pandit 2020-05-21 17:43 ` gregkh 2020-05-21 20:10 ` Jason Gunthorpe 2020-05-20 7:02 ` [net-next v4 02/12] ice: Create and register virtual bus for RDMA Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 03/12] ice: Complete RDMA peer registration Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 04/12] ice: Support resource allocation requests Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 05/12] ice: Enable event notifications Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 06/12] ice: Allow reset operations Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 07/12] ice: Pass through communications to VF Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 08/12] i40e: Move client header location Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 09/12] i40e: Register a virtbus device to provide RDMA Jeff Kirsher 2020-05-20 7:02 ` [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client Jeff Kirsher 2020-05-20 7:20 ` Greg KH 2020-05-20 12:54 ` Jason Gunthorpe 2020-05-20 12:57 ` Jason Gunthorpe 2020-05-21 21:11 ` Ranjani Sridharan 2020-05-21 23:34 ` Jason Gunthorpe 2020-05-22 14:29 ` Pierre-Louis Bossart 2020-05-22 14:55 ` Jason Gunthorpe 2020-05-22 15:33 ` Pierre-Louis Bossart 2020-05-22 17:10 ` Jason Gunthorpe 2020-05-22 18:35 ` Pierre-Louis Bossart 2020-05-22 18:40 ` Jason Gunthorpe 2020-05-22 18:48 ` Pierre-Louis Bossart [this message] 2020-05-22 19:44 ` Jason Gunthorpe 2020-05-22 21:05 ` Pierre-Louis Bossart 2020-06-29 20:59 ` Mark Brown 2020-05-23 6:23 ` Greg KH 2020-05-23 19:41 ` Pierre-Louis Bossart 2020-05-24 6:35 ` Greg KH 2020-05-26 13:15 ` Pierre-Louis Bossart 2020-05-26 13:37 ` Takashi Iwai 2020-05-27 7:17 ` Greg KH 2020-05-27 14:05 ` Pierre-Louis Bossart 2020-06-29 20:33 ` Mark Brown 2020-06-29 22:59 ` Jason Gunthorpe 2020-06-29 23:13 ` Kirsher, Jeffrey T 2020-06-30 10:31 ` Mark Brown 2020-06-30 11:32 ` Jason Gunthorpe 2020-06-30 14:16 ` Mark Brown 2020-06-30 17:24 ` Ranjani Sridharan 2020-06-30 17:27 ` Jason Gunthorpe 2020-07-01 9:50 ` Mark Brown 2020-07-01 23:32 ` Jason Gunthorpe 2020-07-02 11:15 ` Mark Brown 2020-07-02 12:11 ` Jason Gunthorpe 2020-07-02 12:20 ` Mark Brown 2020-07-01 6:59 ` Greg KH 2020-07-02 13:43 ` Ranjani Sridharan 2020-07-06 23:02 ` Dan Williams 2020-07-07 14:16 ` Greg KH 2020-05-25 16:55 ` Jason Gunthorpe 2020-06-29 20:21 ` Mark Brown 2020-06-29 17:36 ` Mark Brown 2020-05-20 7:02 ` [net-next v4 11/12] ASoC: SOF: Create client driver for IPC test Jeff Kirsher 2020-05-20 7:22 ` Greg KH 2020-05-20 12:56 ` Jason Gunthorpe 2020-05-27 20:18 ` Ranjani Sridharan 2020-05-28 0:12 ` Jason Gunthorpe 2020-05-28 1:40 ` Ranjani Sridharan 2020-05-28 10:45 ` Greg KH 2020-06-29 20:37 ` Mark Brown 2020-05-20 7:02 ` [net-next v4 12/12] ASoC: SOF: ops: Add new op for client registration Jeff Kirsher 2020-05-20 7:23 ` Greg KH 2020-05-20 7:17 ` [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Greg KH 2020-05-20 7:25 ` Kirsher, Jeffrey T 2020-05-20 9:08 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions on how to clone and mirror all data and code used for this inbox