From: Saeed Mahameed <saeedm@mellanox.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: Jason Gunthorpe <jgg@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ilan Tayari <ilant@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Adi Nissim <adin@mellanox.com>
Subject: Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log
Date: Wed, 30 May 2018 17:31:37 +0000 [thread overview]
Message-ID: <b836a69b6b9ee7059ff2fbbacbebc67e2ef4e8c1.camel@mellanox.com> (raw)
In-Reply-To: <20180530161720.GE27537@lunn.ch>
On Wed, 2018-05-30 at 18:17 +0200, Andrew Lunn wrote:
> > Hi Andrew, yes the temperature is available by other means, this
> > patch
> > is needed for alert information reasons in order to know which
> > internal
> > sensors triggered the alarm.
> > We are working in parallel to expose temperature sensor to hwmon,
> > but
> > this is still WIP.
> >
> >
> > Is it ok to have both ?
>
> Hi Saeed
>
> Ideally no. hwmon has mechanisms for setting alarm thresholds, and
> indicating the thresholds have been exceeded. There are also ways to
> tie this to thermal zones, so the system can react on overheating,
> slow down the CPU, drop voltages, ramp up fans, etc. hwmon should be
> your primary interface, not dmesg.
>
Yes we are working on this, but it is not something that can happen
soon since we need to define the correct Firmware APIs which are still
WIP.
> But if you are stuck doing things in the wrong order, i guess it is
> O.K. I don't think dmesg is a Binary API, so you can remove it later.
>
Yes this is the plan, once the hwmon is supported we will remove the
extra dmesg warnings.
> Andrew
next prev parent reply other threads:[~2018-05-30 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 0:19 [PATCH mlx5-next 0/2] Mellanox, mlx5 new device events Saeed Mahameed
2018-05-30 0:19 ` [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log Saeed Mahameed
2018-05-30 1:04 ` Andrew Lunn
2018-05-30 15:08 ` Saeed Mahameed
2018-05-30 16:17 ` Andrew Lunn
2018-05-30 17:31 ` Saeed Mahameed [this message]
2018-05-30 0:19 ` [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event Saeed Mahameed
2018-05-30 1:07 ` Andrew Lunn
2018-05-30 15:14 ` Saeed Mahameed
2018-05-30 16:21 ` Andrew Lunn
2018-05-30 17:28 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b836a69b6b9ee7059ff2fbbacbebc67e2ef4e8c1.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=adin@mellanox.com \
--cc=andrew@lunn.ch \
--cc=ilant@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).