From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next v2 9/9] RDMA/rxe: Implement memory access through MWs
Date: Tue, 20 Apr 2021 23:09:34 -0500 [thread overview]
Message-ID: <ca5565ac-6957-791a-f3c3-dda5d31d2802@gmail.com> (raw)
In-Reply-To: <20210420120402.GY1370958@nvidia.com>
On 4/20/21 7:04 AM, Jason Gunthorpe wrote:
> On Tue, Apr 20, 2021 at 02:34:07PM +0800, Zhu Yanjun wrote:
>>> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
>>> index b286a14ec282..9f35e2c042d0 100644
>>> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
>>> @@ -183,6 +183,7 @@ struct rxe_resp_info {
>>>
>>> /* RDMA read / atomic only */
>>> u64 va;
>>> + u64 offset;
>>> struct rxe_mr *mr;
>>> u32 resid;
>>> u32 rkey;
>>> @@ -470,6 +471,16 @@ static inline u32 mr_rkey(struct rxe_mr *mr)
>>> return mr->ibmr.rkey;
>>> }
>>>
>>> +static inline struct rxe_pd *mw_pd(struct rxe_mw *mw)
>>
>> inline
>> Can we remove inline keyword and let the compile to decide it?
>
> Not in a header
>
> Jason
>
I think this is the cleanest way to add these trivial functions. They don't really generate any code
just a different offset from the pointer.
Bob
prev parent reply other threads:[~2021-04-21 4:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 2:54 [PATCH for-next v2 0/9] RDMA/rxe: Implement memory windows Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 1/9] RDMA/rxe: Add bind MW fields to rxe_send_wr Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 2/9] RDMA/rxe: Return errors for add index and key Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 3/9] RDMA/rxe: Enable MW object pool Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 4/9] RDMA/rxe: Add ib_alloc_mw and ib_dealloc_mw verbs Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 5/9] RDMA/rxe: Replace WR_REG_MASK by WR_LOCAL_OP_MASK Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 6/9] RDMA/rxe: Move local ops to subroutine Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 7/9] RDMA/rxe: Add support for bind MW work requests Bob Pearson
2021-04-20 14:32 ` Zhu Yanjun
2021-04-21 4:24 ` Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 8/9] RDMA/rxe: Implement invalidate MW operations Bob Pearson
2021-04-20 6:38 ` Zhu Yanjun
2021-04-21 4:22 ` Bob Pearson
2021-04-15 2:54 ` [PATCH for-next v2 9/9] RDMA/rxe: Implement memory access through MWs Bob Pearson
2021-04-20 6:34 ` Zhu Yanjun
2021-04-20 12:04 ` Jason Gunthorpe
2021-04-21 4:09 ` Bob Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca5565ac-6957-791a-f3c3-dda5d31d2802@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).