From: Rao Shoaib <rao.shoaib@oracle.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: monis@mellanox.com, dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Introduce maximum WQE size to check limits
Date: Tue, 17 Dec 2019 11:38:52 -0800 [thread overview]
Message-ID: <ccceac68-db4f-77a3-500d-12f60a8a1354@oracle.com> (raw)
In-Reply-To: <20191120000840.GQ4991@ziepe.ca>
Any update on my patch?
If there is some change needed please let me know.
Shoaib
On 11/19/19 4:08 PM, Jason Gunthorpe wrote:
> On Tue, Nov 19, 2019 at 03:55:35PM -0800, Rao Shoaib wrote:
>
>> My intent is that we calculate and use the maximum buffer size using the
>> maximum of, number of SGE's and inline data requested, not controlling the
>> size of WQE buffer. If I was trying to limit WQE size I would agree with
>> you. Defining MAX_WQE_SIZE based on MAX_SGE and recalculating MAX_SGE does
>> not make sense to me. MAX_SGE and inline_data are independent variables and
>> define the size of wqe size not the other wise around. I did make
>> inline_dependent on MAX_SGE.
> What you are trying to do is limit the size of the WQE to some maximum
> and from there you can compute the upper limit on the SGE and the
> inline data arrays, depending on how the WQE is being used.
>
> If a limit must be had then the limit is the WQE size. It is also
> reasonable to ask why rxe has a limit at all, or why the limit is so
> small ie why can't it be 2k or something? But that is something else
>
> Jason
next prev parent reply other threads:[~2019-12-17 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 19:54 [PATCH v2 0/2] rxe should use same buffer size for SGE's and inline data rao Shoaib
2019-11-18 19:54 ` [PATCH v2 1/2] Introduce maximum WQE size to check limits rao Shoaib
2019-11-19 20:31 ` Jason Gunthorpe
2019-11-19 22:38 ` Rao Shoaib
2019-11-19 23:13 ` Jason Gunthorpe
2019-11-19 23:55 ` Rao Shoaib
2019-11-20 0:08 ` Jason Gunthorpe
2019-12-17 19:38 ` Rao Shoaib [this message]
2019-12-19 18:25 ` Jason Gunthorpe
2019-12-19 18:37 ` Rao Shoaib
2020-01-13 18:35 ` Rao Shoaib
2020-01-13 18:47 ` Jason Gunthorpe
2020-01-13 19:16 ` Rao Shoaib
2019-11-18 19:54 ` [PATCH v2 2/2] SGE buffer and max_inline data must have same size rao Shoaib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccceac68-db4f-77a3-500d-12f60a8a1354@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).