linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Haim Boozaglo <haimbo@mellanox.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Subject: Re: "ibstat -l" displays CA device list in an unsorted order
Date: Tue, 25 Feb 2020 10:25:49 +0200	[thread overview]
Message-ID: <d3b6297e-3251-ec14-ebef-541eb3a98eae@mellanox.com> (raw)
In-Reply-To: <20200224194131.GV31668@ziepe.ca>



On 2/24/2020 9:41 PM, Jason Gunthorpe wrote:
> On Mon, Feb 24, 2020 at 08:06:56PM +0200, Haim Boozaglo wrote:
>> Hi all,
>>
>> When running "ibstat" or "ibstat -l", the output of CA device list
>> is displayed in an unsorted order.
>>
>> Before pull request #561, ibstat displayed the CA device list sorted in
>> alphabetical order.
>>
>> The problem is that users expect to have the output sorted in alphabetical
>> order and now they get it not as expected (in an unsorted order).
> 
> Really? Why? That doesn't look like it should happen, the list is
> constructed out of readdir() which should be sorted?
> 
> Do you know where this comes from?
> 
> Jason
> 

readdir() gives us struct by struct and doesn't keep on alphabetical order.
Before pull request #561 ibstat have used this API of libibumad:
int umad_get_cas_names(char cas[][UMAD_CA_NAME_LEN], int max)

This API used this function:
n = scandir(SYS_INFINIBAND, &namelist, NULL, alphasort);

scandir() can return a sorted CA device list in alphabetical order.

Thanks,
Haim.

  reply	other threads:[~2020-02-25  8:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 18:06 "ibstat -l" displays CA device list in an unsorted order Haim Boozaglo
2020-02-24 19:41 ` Jason Gunthorpe
2020-02-25  8:25   ` Haim Boozaglo [this message]
2020-02-26 13:43     ` Jason Gunthorpe
2020-02-26 13:57       ` Leon Romanovsky
2020-02-26 17:09         ` Jason Gunthorpe
2020-02-27  7:48           ` Haim Boozaglo
2020-02-27 12:49             ` Leon Romanovsky
2020-02-27 12:57               ` Vladimir Koushnir
2020-02-27 13:59                 ` Leon Romanovsky
2020-02-27 13:33             ` Jason Gunthorpe
2020-02-27 14:55               ` Dennis Dalessandro
2020-02-27 15:26                 ` Jason Gunthorpe
2020-02-25  7:48 ` Leon Romanovsky
2020-02-25  8:36   ` Haim Boozaglo
2020-02-25  9:18     ` Leon Romanovsky
2020-02-25 17:18       ` Jens Domke
2020-02-25 19:43         ` Leon Romanovsky
2020-02-26 13:42           ` Dennis Dalessandro
2020-02-26 13:56             ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3b6297e-3251-ec14-ebef-541eb3a98eae@mellanox.com \
    --to=haimbo@mellanox.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).