Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param
@ 2019-10-09 16:49 Donald Dutile
  2019-10-09 21:55 ` Bart Van Assche
  0 siblings, 1 reply; 2+ messages in thread
From: Donald Dutile @ 2019-10-09 16:49 UTC (permalink / raw)
  To: linux-rdma; +Cc: ddutile

Long-time missing new-line in sysfs output.
Simply add it.

Signed-off-by: Donald Dutile <ddutile@redhat.com>
---
 drivers/infiniband/ulp/srp/ib_srp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index cee855e85705..8fff3d6bce53 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -165,9 +165,9 @@ static int srp_tmo_get(char *buffer, const struct kernel_param *kp)
 	int tmo = *(int *)kp->arg;
 
 	if (tmo >= 0)
-		return sprintf(buffer, "%d", tmo);
+		return sprintf(buffer, "%d\n", tmo);
 	else
-		return sprintf(buffer, "off");
+		return sprintf(buffer, "off\n");
 }
 
 static int srp_tmo_set(const char *val, const struct kernel_param *kp)
-- 
2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param
  2019-10-09 16:49 [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param Donald Dutile
@ 2019-10-09 21:55 ` Bart Van Assche
  0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2019-10-09 21:55 UTC (permalink / raw)
  To: Donald Dutile, linux-rdma

On 10/9/19 9:49 AM, Donald Dutile wrote:
> Long-time missing new-line in sysfs output.
> Simply add it.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 16:49 [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param Donald Dutile
2019-10-09 21:55 ` Bart Van Assche

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org linux-rdma@archiver.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/ public-inbox