* [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param
@ 2019-10-09 16:49 Donald Dutile
2019-10-09 21:55 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Donald Dutile @ 2019-10-09 16:49 UTC (permalink / raw)
To: linux-rdma; +Cc: ddutile
Long-time missing new-line in sysfs output.
Simply add it.
Signed-off-by: Donald Dutile <ddutile@redhat.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index cee855e85705..8fff3d6bce53 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -165,9 +165,9 @@ static int srp_tmo_get(char *buffer, const struct kernel_param *kp)
int tmo = *(int *)kp->arg;
if (tmo >= 0)
- return sprintf(buffer, "%d", tmo);
+ return sprintf(buffer, "%d\n", tmo);
else
- return sprintf(buffer, "off");
+ return sprintf(buffer, "off\n");
}
static int srp_tmo_set(const char *val, const struct kernel_param *kp)
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param
2019-10-09 16:49 [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param Donald Dutile
@ 2019-10-09 21:55 ` Bart Van Assche
2019-10-21 20:55 ` Doug Ledford
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2019-10-09 21:55 UTC (permalink / raw)
To: Donald Dutile, linux-rdma
On 10/9/19 9:49 AM, Donald Dutile wrote:
> Long-time missing new-line in sysfs output.
> Simply add it.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param
2019-10-09 21:55 ` Bart Van Assche
@ 2019-10-21 20:55 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2019-10-21 20:55 UTC (permalink / raw)
To: Bart Van Assche, Donald Dutile, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
On Wed, 2019-10-09 at 14:55 -0700, Bart Van Assche wrote:
> On 10/9/19 9:49 AM, Donald Dutile wrote:
> > Long-time missing new-line in sysfs output.
> > Simply add it.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks, applied to for-next.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-21 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 16:49 [PATCH] ib/srp: Add missing new line after displaying fast_io_fail_tmo param Donald Dutile
2019-10-09 21:55 ` Bart Van Assche
2019-10-21 20:55 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).