Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH][next] net/mlx5: fix kvfree of uninitialized pointer spec
@ 2019-11-05 18:27 Colin King
  2019-11-06  6:24 ` Saeed Mahameed
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-11-05 18:27 UTC (permalink / raw)
  To: Saeed Mahameed, Leon Romanovsky, David S . Miller, Parav Pandit,
	netdev, linux-rdma
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Currently when a call to  esw_vport_create_legacy_ingress_acl_group
fails the error exit path to label 'out' will cause a kvfree on the
uninitialized pointer spec.  Fix this by ensuring pointer spec is
initialized to NULL to avoid this issue.

Addresses-Coverity: ("Uninitialized pointer read")
Fixes: 10652f39943e ("net/mlx5: Refactor ingress acl configuration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
index 7baade9e62b7..f2e400a23a59 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -1253,7 +1253,7 @@ static int esw_vport_ingress_config(struct mlx5_eswitch *esw,
 	struct mlx5_flow_destination drop_ctr_dst = {0};
 	struct mlx5_flow_destination *dst = NULL;
 	struct mlx5_flow_act flow_act = {0};
-	struct mlx5_flow_spec *spec;
+	struct mlx5_flow_spec *spec = NULL;
 	int dest_num = 0;
 	int err = 0;
 	u8 *smac_v;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] net/mlx5: fix kvfree of uninitialized pointer spec
  2019-11-05 18:27 [PATCH][next] net/mlx5: fix kvfree of uninitialized pointer spec Colin King
@ 2019-11-06  6:24 ` Saeed Mahameed
  0 siblings, 0 replies; 2+ messages in thread
From: Saeed Mahameed @ 2019-11-06  6:24 UTC (permalink / raw)
  To: Parav Pandit, linux-rdma, colin.king, davem, leon, netdev
  Cc: kernel-janitors, linux-kernel

On Tue, 2019-11-05 at 18:27 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently when a call to  esw_vport_create_legacy_ingress_acl_group
> fails the error exit path to label 'out' will cause a kvfree on the
> uninitialized pointer spec.  Fix this by ensuring pointer spec is
> initialized to NULL to avoid this issue.
> 
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: 10652f39943e ("net/mlx5: Refactor ingress acl configuration")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index 7baade9e62b7..f2e400a23a59 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -1253,7 +1253,7 @@ static int esw_vport_ingress_config(struct
> mlx5_eswitch *esw,
>  	struct mlx5_flow_destination drop_ctr_dst = {0};
>  	struct mlx5_flow_destination *dst = NULL;
>  	struct mlx5_flow_act flow_act = {0};
> -	struct mlx5_flow_spec *spec;
> +	struct mlx5_flow_spec *spec = NULL;
>  	int dest_num = 0;
>  	int err = 0;
>  	u8 *smac_v;


Applied to mlx5-next.
Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 18:27 [PATCH][next] net/mlx5: fix kvfree of uninitialized pointer spec Colin King
2019-11-06  6:24 ` Saeed Mahameed

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git