From: santosh.shilimkar@oracle.com
To: John Hubbard <jhubbard@nvidia.com>,
syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com
Cc: akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
rds-devel@oss.oracle.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] rds: fix crash in rds_info_getsockopt()
Date: Wed, 20 May 2020 12:43:39 -0700 [thread overview]
Message-ID: <d848c10e-1d04-3669-0d0f-5b53505686b1@oracle.com> (raw)
In-Reply-To: <20200520194147.127137-1-jhubbard@nvidia.com>
On 5/20/20 12:41 PM, John Hubbard wrote:
> The conversion to pin_user_pages() had a bug: it overlooked
> the case of allocation of pages failing. Fix that by restoring
> an equivalent check.
>
> Reported-by: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com
> Fixes: dbfe7d74376e ("rds: convert get_user_pages() --> pin_user_pages()")
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Cc: linux-rdma@vger.kernel.org
> Cc: rds-devel@oss.oracle.com
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
Thanks John !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
next prev parent reply other threads:[~2020-05-20 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 18:12 general protection fault in unpin_user_pages syzbot
2020-05-20 19:41 ` [PATCH] rds: fix crash in rds_info_getsockopt() John Hubbard
2020-05-20 19:43 ` santosh.shilimkar [this message]
2020-05-20 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d848c10e-1d04-3669-0d0f-5b53505686b1@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jhubbard@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).